Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305063007: Oilpan: Remove WillBeRawPtr<TimingFunction> (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Remove WillBeRawPtr<TimingFunction> TimingFunction is off-heap, so it's just wrong to use WillBe types. This CL removes them. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/animation/KeyframeEffectModel.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL. Just a clean-up patch.
5 years, 3 months ago (2015-09-03 06:06:14 UTC) #2
Yuta Kitamura
lgtm
5 years, 3 months ago (2015-09-03 06:27:50 UTC) #4
keishi
lgtm
5 years, 3 months ago (2015-09-03 06:27:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305063007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305063007/1
5 years, 3 months ago (2015-09-03 07:16:45 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 09:36:27 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201713

Powered by Google App Engine
This is Rietveld 408576698