Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305043007: Don't trace LayoutObject geometry prior to running layout. (Closed)

Created:
5 years, 3 months ago by szager1
Modified:
5 years, 1 month ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix duplicate traceGeometry parameter. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M Source/core/frame/FrameView.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/TracedLayoutObject.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/TracedLayoutObject.cpp View 5 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
szager1
5 years, 3 months ago (2015-09-03 22:32:16 UTC) #1
szager1
https://codereview.chromium.org/1305043007/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/1305043007/diff/1/Source/core/frame/FrameView.cpp#newcode1041 Source/core/frame/FrameView.cpp:1041: TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(TRACE_DISABLED_BY_DEFAULT("blink.debug.layout"), "LayoutTree", Moving this after updateLayerPositionsAfterLayout() is necessary to ...
5 years, 3 months ago (2015-09-03 22:34:41 UTC) #2
dsinclair
lgtm
5 years, 3 months ago (2015-09-04 13:21:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305043007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305043007/20001
5 years, 3 months ago (2015-09-04 13:21:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/109130)
5 years, 3 months ago (2015-09-04 14:34:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305043007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305043007/40001
5 years, 3 months ago (2015-09-04 20:37:03 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201825
5 years, 3 months ago (2015-09-04 21:59:55 UTC) #11
michaelpg
5 years, 1 month ago (2015-10-27 21:34:37 UTC) #13
Message was sent while issue was closed. 
This seems to be the only potentially relevant CL in the bisect for
http://crbug.com/528944. Would anyone be able to confirm this on OS X?

Powered by Google App Engine
This is Rietveld 408576698