Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 var PermissionsHelper = (function() { | |
| 2 function nameToObject(permissionName) { | |
| 3 switch (permissionName) { | |
| 4 case "midi": | |
| 5 return {name: "midi"} | |
|
mlamouri (slow - plz ping)
2015/08/22 10:19:29
nit: add ;
same for all the following return stat
Lalit Maganti
2015/08/24 09:18:23
Done.
| |
| 6 case "midi-sysex": | |
| 7 return {name: "midi", sysex: true} | |
| 8 case "push-messaging": | |
| 9 return {name: "push", userVisibleOnly: true} | |
| 10 case "notifications": | |
| 11 return {name: "notifications"} | |
| 12 case "geolocation": | |
| 13 return {name: "geolocation"} | |
| 14 default: | |
| 15 throw "Invalid " | |
|
mlamouri (slow - plz ping)
2015/08/22 10:19:29
nit: could you throw something that would be more
Lalit Maganti
2015/08/24 09:18:23
I really shouldn't write CLs late on Friday :)
Do
| |
| 16 } | |
| 17 } | |
| 18 | |
| 19 return { | |
| 20 setPermission: function(name, state) { | |
| 21 return new Promise(function(resolver, reject) { | |
| 22 navigator.permissions.query(nameToObject(name)).then(function(result) { | |
| 23 if (result.state == state) { | |
| 24 resolver() | |
| 25 return; | |
| 26 } | |
| 27 | |
| 28 result.onchange = function() { | |
| 29 result.onchange = null; | |
| 30 resolver(); | |
| 31 }; | |
| 32 | |
| 33 testRunner.setPermission(name, state, location.origin, location.orig in); | |
| 34 }); | |
| 35 }); | |
| 36 } | |
| 37 } | |
| 38 })(); | |
| OLD | NEW |