Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 130503013: Remove TreatNullAs=NullString for SVGScriptElement.type (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
CC:
blink-reviews, krit, arv+blink, f(malita), Inactive, pdr, Stephen Chennney, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

Remove TreatNullAs=NullString for SVGScriptElement.type http://www.w3.org/TR/SVG/script.html#InterfaceSVGScriptElement The test passes in Firefox Nightly and IE11 Release Preview, but fails in Opera 12.16. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-18 04:41:31 UTC) #1
pdr.
On 2014/01/18 04:41:31, philipj wrote: LGTM
6 years, 11 months ago (2014-01-19 03:16:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/130503013/1
6 years, 11 months ago (2014-01-19 03:16:39 UTC) #3
commit-bot: I haz the power
Change committed as 165366
6 years, 11 months ago (2014-01-19 03:36:41 UTC) #4
arv (Not doing code reviews)
6 years, 11 months ago (2014-01-21 15:15:41 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698