Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: build/common.gypi

Issue 130503011: Allow the asan_coverage GYP flag to accept arbitrary values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 9edde19347a42fb44649d59062a0494d0ac20603..a99006419355625a1fcb2fffffc13b139846543b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -353,7 +353,8 @@
# -fsanitize=address only works with clang, but asan=1 implies clang=1
# See https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer
'asan%': 0,
- # Enable coverage gathering instrumentation in ASan.
+ # Enable coverage gathering instrumentation in ASan. This flag also
+ # controls coverage granularity (experimental).
'asan_coverage%': 0,
# Enable building with LSan (Clang's -fsanitize=leak option).
@@ -3456,11 +3457,11 @@
}],
],
}],
- ['asan_coverage==1', {
+ ['asan_coverage!=0', {
'target_conditions': [
['_toolset=="target"', {
'cflags': [
- '-mllvm -asan-coverage=1',
+ '-mllvm -asan-coverage=<(asan_coverage)',
],
}],
],
@@ -4120,11 +4121,11 @@
'MEMORY_TOOL_REPLACES_ALLOCATOR',
],
}],
- ['asan_coverage==1', {
+ ['asan_coverage!=0', {
'target_conditions': [
['_toolset=="target"', {
'cflags': [
- '-mllvm -asan-coverage=1',
+ '-mllvm -asan-coverage=<(asan_coverage)',
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698