Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 130503003: Revert "Add support for closing Android Shell instances from Java." (Closed)

Created:
6 years, 11 months ago by dcheng
Modified:
6 years, 11 months ago
Reviewers:
Ted C, Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Revert "Add support for closing Android Shell instances from Java." This causes some layout tests on Android to crash with a NPE. TBR=tedchoc@chromium.org,avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -105 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 3 chunks +1 line, -32 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 4 chunks +5 lines, -6 lines 0 comments Download
D content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellShellManagementTest.java View 1 chunk +0 lines, -47 lines 0 comments Download
M content/shell/android/shell_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/android/shell_manager.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/shell/browser/shell_android.cc View 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcheng
Sample failures can be seen here: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/7895 Crash logs can be seen by navigating to ...
6 years, 11 months ago (2014-01-10 07:34:29 UTC) #1
dcheng
6 years, 11 months ago (2014-01-10 07:35:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698