Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: Source/core/css/CSSValue.cpp

Issue 1304993002: Change Rect and Quad to be CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_counter_out_attempt_3
Patch Set: Removed empty destructor Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSValue.cpp
diff --git a/Source/core/css/CSSValue.cpp b/Source/core/css/CSSValue.cpp
index cae937c0faa8c7177c5b8d4b6ed4faadcb6cc67f..b218dde2e3b1fd7e17c5c9cdd71dac9c285df771 100644
--- a/Source/core/css/CSSValue.cpp
+++ b/Source/core/css/CSSValue.cpp
@@ -46,6 +46,7 @@
#include "core/css/CSSLineBoxContainValue.h"
#include "core/css/CSSPathValue.h"
#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/CSSQuadValue.h"
#include "core/css/CSSReflectValue.h"
#include "core/css/CSSSVGDocumentValue.h"
#include "core/css/CSSShadowValue.h"
@@ -129,6 +130,8 @@ bool CSSValue::equals(const CSSValue& other) const
return compareCSSValues<CSSPathValue>(*this, other);
case PrimitiveClass:
return compareCSSValues<CSSPrimitiveValue>(*this, other);
+ case QuadClass:
+ return compareCSSValues<CSSQuadValue>(*this, other);
case ReflectClass:
return compareCSSValues<CSSReflectValue>(*this, other);
case ShadowClass:
@@ -196,6 +199,8 @@ String CSSValue::cssText() const
return toCSSPathValue(this)->customCSSText();
case PrimitiveClass:
return toCSSPrimitiveValue(this)->customCSSText();
+ case QuadClass:
+ return toCSSQuadValue(this)->customCSSText();
case ReflectClass:
return toCSSReflectValue(this)->customCSSText();
case ShadowClass:
@@ -278,6 +283,9 @@ void CSSValue::destroy()
case PrimitiveClass:
delete toCSSPrimitiveValue(this);
return;
+ case QuadClass:
+ delete toCSSQuadValue(this);
+ return;
case ReflectClass:
delete toCSSReflectValue(this);
return;
@@ -369,6 +377,9 @@ void CSSValue::finalizeGarbageCollectedObject()
case PrimitiveClass:
toCSSPrimitiveValue(this)->~CSSPrimitiveValue();
return;
+ case QuadClass:
+ toCSSQuadValue(this)->~CSSQuadValue();
+ return;
case ReflectClass:
toCSSReflectValue(this)->~CSSReflectValue();
return;
@@ -460,6 +471,9 @@ DEFINE_TRACE(CSSValue)
case PrimitiveClass:
toCSSPrimitiveValue(this)->traceAfterDispatch(visitor);
return;
+ case QuadClass:
+ toCSSQuadValue(this)->traceAfterDispatch(visitor);
+ return;
case ReflectClass:
toCSSReflectValue(this)->traceAfterDispatch(visitor);
return;

Powered by Google App Engine
This is Rietveld 408576698