Source/core/css/CSSCalculationValue.cpp - Issue 1304993002: Change Rect and Quad to be CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 1304993002: Change Rect and Quad to be CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_counter_out_attempt_3

Patch Set: Small change to generated style builder functions Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCalculationValue.cpp

diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp

index 9c51edf952265ded20812e40113988e6e357378f..b96889e677b2e965eb21999fe529f7724875ee31 100644

--- a/Source/core/css/CSSCalculationValue.cpp

+++ b/Source/core/css/CSSCalculationValue.cpp

@@ -124,11 +124,9 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitType type)

case CSSPrimitiveValue::UnitType::String:

case CSSPrimitiveValue::UnitType::URI:

case CSSPrimitiveValue::UnitType::Attribute:

- case CSSPrimitiveValue::UnitType::Rect:

case CSSPrimitiveValue::UnitType::RGBColor:

case CSSPrimitiveValue::UnitType::Pair:

case CSSPrimitiveValue::UnitType::Shape:

- case CSSPrimitiveValue::UnitType::Quad:

case CSSPrimitiveValue::UnitType::Calc:

case CSSPrimitiveValue::UnitType::CalcPercentageWithNumber:

case CSSPrimitiveValue::UnitType::CalcPercentageWithLength:

« no previous file with comments | « Source/core/css/CSSBorderImageSliceValue.cpp ('k') | Source/core/css/CSSPrimitiveValue.h » ('j') | no next file with comments »