Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304983005: Revert of Change VideoCaptureDeliverFrameCB's signature (Closed)

Created:
5 years, 4 months ago by fgorski
Modified:
5 years, 4 months ago
Reviewers:
bbudge, mcasas, DaleCurtis, ajose
CC:
chromium-reviews, hclam+watch_chromium.org, posciak+watch_chromium.org, jam, imcheng+watch_chromium.org, mlamouri+watch-content_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change VideoCaptureDeliverFrameCB's signature (patchset #1 id:1 of https://codereview.chromium.org/1304393004/ ) Reason for revert: Compilation failure: http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/7840/steps/compile/logs/stdio Original issue's description: > Change VideoCaptureDeliverFrameCB's signature from > |const base::TimeTicks&| to |base::TimeTicks|. > > BUG=524589 > > Committed: https://crrev.com/90685ba0c19e0de94116eb4eac5a6d355e1aac20 > Cr-Commit-Position: refs/heads/master@{#345453} TBR=mcasas@chromium.org,dalecurtis@chromium.org,bbudge@chromium.org,ajose@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524589 Committed: https://crrev.com/01a943f5443aa9d7882a660bd1f3753a2dbaf566 Cr-Commit-Position: refs/heads/master@{#345458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capture_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/video_source_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_adapter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_track_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_capturer_source.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fgorski
Created Revert of Change VideoCaptureDeliverFrameCB's signature
5 years, 4 months ago (2015-08-25 22:26:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304983005/1
5 years, 4 months ago (2015-08-25 22:27:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 22:29:17 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 22:29:50 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/01a943f5443aa9d7882a660bd1f3753a2dbaf566
Cr-Commit-Position: refs/heads/master@{#345458}

Powered by Google App Engine
This is Rietveld 408576698