media/audio/win/core_audio_util_win.cc - Issue 1304973005: Refactor AudioParameters member setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/core_audio_util_win.cc

Issue 1304973005: Refactor AudioParameters member setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dalecurtis comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/win/core_audio_util_win.cc

diff --git a/media/audio/win/core_audio_util_win.cc b/media/audio/win/core_audio_util_win.cc

index 8442fc1bc11983fded607069a7401d18fd1c596d..1ce01911eee08c0128d8fd9c4c4348ea27d95265 100644

--- a/media/audio/win/core_audio_util_win.cc

+++ b/media/audio/win/core_audio_util_win.cc

@@ -772,7 +772,7 @@ HRESULT CoreAudioUtil::GetPreferredAudioParameters(const std::string& device_id,

// TODO(dalecurtis): Old code rewrote != 1 channels to stereo, do we still

// need to do the same thing?

if (params->channels() != 1) {

- params->Reset(params->format(), CHANNEL_LAYOUT_STEREO, 2,

+ params->Reset(params->format(), CHANNEL_LAYOUT_STEREO,

params->sample_rate(), params->bits_per_sample(),

params->frames_per_buffer());

}