media/audio/mac/audio_manager_mac.cc - Issue 1304973005: Refactor AudioParameters member setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/mac/audio_manager_mac.cc

Issue 1304973005: Refactor AudioParameters member setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dalecurtis comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/mac/audio_manager_mac.cc

diff --git a/media/audio/mac/audio_manager_mac.cc b/media/audio/mac/audio_manager_mac.cc

index 42651ffbea8afe2190c75fa36b3b036a5b17c8ce..33dbfdfcb4ee45e310402e3bc04c4450d6411510 100644

--- a/media/audio/mac/audio_manager_mac.cc

+++ b/media/audio/mac/audio_manager_mac.cc

@@ -672,9 +672,10 @@ AudioParameters AudioManagerMac::GetPreferredOutputStreamParameters(

channel_layout = CHANNEL_LAYOUT_DISCRETE;

}

- return AudioParameters(

- AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout, output_channels,

- hardware_sample_rate, 16, buffer_size, AudioParameters::NO_EFFECTS);

+ AudioParameters params(AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,

+ hardware_sample_rate, 16, buffer_size);

+ params.set_channels_for_discrete(output_channels);

+ return params;

}

void AudioManagerMac::InitializeOnAudioThread() {