Chromium Code Reviews

Unified Diff: media/audio/android/audio_manager_android.cc

Issue 1304973005: Refactor AudioParameters member setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dalecurtis comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: media/audio/android/audio_manager_android.cc
diff --git a/media/audio/android/audio_manager_android.cc b/media/audio/android/audio_manager_android.cc
index 0590ffcc1443f3b92965ea98e915ce6e197dc72e..e231cd1ce20a5e6322daef04534b45f1c3403c1b 100644
--- a/media/audio/android/audio_manager_android.cc
+++ b/media/audio/android/audio_manager_android.cc
@@ -140,9 +140,9 @@ AudioParameters AudioManagerAndroid::GetInputStreamParameters(
if (user_buffer_size)
buffer_size = user_buffer_size;
- AudioParameters params(
- AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
- GetNativeOutputSampleRate(), 16, buffer_size, effects);
+ AudioParameters params(AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
+ GetNativeOutputSampleRate(), 16, buffer_size);
+ params.set_effects(effects);
return params;
}
@@ -306,9 +306,8 @@ AudioParameters AudioManagerAndroid::GetPreferredOutputStreamParameters(
if (user_buffer_size)
buffer_size = user_buffer_size;
- return AudioParameters(
- AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
- sample_rate, bits_per_sample, buffer_size, AudioParameters::NO_EFFECTS);
+ return AudioParameters(AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
+ sample_rate, bits_per_sample, buffer_size);
}
bool AudioManagerAndroid::HasNoAudioInputStreams() {

Powered by Google App Engine