Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 1304973005: Refactor AudioParameters member setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cross-platform fixes. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_platform_audio_input.cc ('k') | media/audio/alsa/audio_manager_alsa.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_blink_platform_impl.cc
diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc
index 3b939845fe7cd1b24159043f610f1b06062df992..5591ddf96bff57cf4c38fa736095832b926bdeaa 100644
--- a/content/renderer/renderer_blink_platform_impl.cc
+++ b/content/renderer/renderer_blink_platform_impl.cc
@@ -163,7 +163,7 @@ base::LazyInstance<blink::WebDeviceOrientationData>::Leaky
// not owned by us.
blink::WebBatteryStatusListener* g_test_battery_status_listener = nullptr;
-} // namespace
+} // namespace
//------------------------------------------------------------------------------
@@ -737,10 +737,10 @@ WebAudioDevice* RendererBlinkPlatformImpl::createAudioDevice(
// For CHANNEL_LAYOUT_DISCRETE, pass the explicit channel count along with
// the channel layout when creating an |AudioParameters| object.
- media::AudioParameters params(
- media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
- layout, channels, static_cast<int>(sample_rate), 16, buffer_size,
- media::AudioParameters::NO_EFFECTS);
+ media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
+ layout, static_cast<int>(sample_rate), 16,
+ buffer_size);
+ params.set_channels_for_discrete(channels);
return new RendererWebAudioDeviceImpl(params, callback, session_id);
}
@@ -995,7 +995,7 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3D(
break;
default:
NOTREACHED();
- };
+ }
}
WebGraphicsContext3DCommandBufferImpl::SharedMemoryLimits limits;
« no previous file with comments | « content/renderer/pepper/pepper_platform_audio_input.cc ('k') | media/audio/alsa/audio_manager_alsa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698