Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: content/renderer/media/webrtc_local_audio_source_provider_unittest.cc

Issue 1304973005: Refactor AudioParameters member setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cross-platform fixes. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
diff --git a/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc b/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
index 82ff8f5f02e5006c92f2a050fc0b3f869d47c29f..e921bc98033eff8aa222d6ef85441604a9e96235 100644
--- a/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
+++ b/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
@@ -21,10 +21,10 @@ class WebRtcLocalAudioSourceProviderTest : public testing::Test {
protected:
void SetUp() override {
source_params_.Reset(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
- media::CHANNEL_LAYOUT_MONO, 1, 48000, 16, 480);
+ media::CHANNEL_LAYOUT_MONO, 48000, 16, 480);
sink_params_.Reset(
media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
- media::CHANNEL_LAYOUT_STEREO, 2, 44100, 16,
+ media::CHANNEL_LAYOUT_STEREO, 44100, 16,
WebRtcLocalAudioSourceProvider::kWebAudioRenderBufferSize);
sink_bus_ = media::AudioBus::Create(sink_params_);
MockMediaConstraintFactory constraint_factory;
@@ -73,7 +73,7 @@ TEST_F(WebRtcLocalAudioSourceProviderTest, VerifyDataFlow) {
// source_params_.frames_per_buffer() of zero into the resampler since there
// no available data in the FIFO.
source_provider_->provideInput(audio_data, sink_params_.frames_per_buffer());
- EXPECT_TRUE(sink_bus_->channel(0)[0] == 0);
+ EXPECT_EQ(0, sink_bus_->channel(0)[0]);
// Create a source AudioBus with channel data filled with non-zero values.
const scoped_ptr<media::AudioBus> source_bus =

Powered by Google App Engine
This is Rietveld 408576698