Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5897)

Unified Diff: chrome/browser/media/webrtc_browsertest_audio.cc

Issue 1304973005: Refactor AudioParameters member setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cross-platform. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_browsertest_audio.cc
diff --git a/chrome/browser/media/webrtc_browsertest_audio.cc b/chrome/browser/media/webrtc_browsertest_audio.cc
index 41cbc7eadc98853b277d1bb6afbbefcd8301199f..1f7defec05711daa6034e78cbd1967d0ab2bfd3c 100644
--- a/chrome/browser/media/webrtc_browsertest_audio.cc
+++ b/chrome/browser/media/webrtc_browsertest_audio.cc
@@ -79,8 +79,9 @@ float ComputeAudioEnergyForWavFile(const base::FilePath& wav_filename,
file_parameters->Reset(
media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
media::GuessChannelLayout(wav_audio_handler->num_channels()),
- wav_audio_handler->num_channels(), wav_audio_handler->sample_rate(),
- wav_audio_handler->bits_per_sample(), wav_audio_handler->total_frames());
+ wav_audio_handler->sample_rate(), wav_audio_handler->bits_per_sample(),
+ wav_audio_handler->total_frames());
+ file_parameters->set_channels_for_discrete(wav_audio_handler->num_channels());
DaleCurtis 2015/09/04 17:03:39 Hmm, I'm not a fan of this calling pattern, but it
ajm 2015/09/04 19:02:53 Yeah I'm not completely satisfied with it either,
tommi (sloooow) - chröme 2015/09/05 09:49:57 Ack. No better suggestions atm.
return power_monitor.ReadCurrentPowerAndClip().first;
}

Powered by Google App Engine
This is Rietveld 408576698