Refactor AudioParameters member setting.

content/browser/media/media_internals_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/media_internals.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/run_loop.h"
@@ skipping 209 matching lines @@
   ExpectString("captureApi", "QTKit");
 #elif defined(OS_ANDROID)
   ExpectString("captureApi", "Camera API2 Legacy");
 #endif
 }
 
 class MediaInternalsAudioLogTest
     : public MediaInternalsTestBase,
       public testing::TestWithParam<media::AudioLogFactory::AudioComponent> {
  public:
-  MediaInternalsAudioLogTest() :
-      update_cb_(base::Bind(&MediaInternalsAudioLogTest::UpdateCallbackImpl,
-                            base::Unretained(this))),
-      test_params_(media::AudioParameters::AUDIO_PCM_LINEAR,
-                   media::CHANNEL_LAYOUT_MONO,
-                   48000,
-                   16,
-                   128,
-                   media::AudioParameters::ECHO_CANCELLER |
-                   media::AudioParameters::DUCKING),
-      test_component_(GetParam()),
-      audio_log_(media_internals_->CreateAudioLog(test_component_)) {
+  MediaInternalsAudioLogTest()
+      : update_cb_(base::Bind(&MediaInternalsAudioLogTest::UpdateCallbackImpl,
+                              base::Unretained(this))),
+        test_params_(MakeAudioParams()),
+        test_component_(GetParam()),
+        audio_log_(media_internals_->CreateAudioLog(test_component_)) {
     media_internals_->AddUpdateCallback(update_cb_);
   }
 
   virtual ~MediaInternalsAudioLogTest() {
     media_internals_->RemoveUpdateCallback(update_cb_);
   }
 
  protected:
   MediaInternals::UpdateCallback update_cb_;
   const media::AudioParameters test_params_;
   const media::AudioLogFactory::AudioComponent test_component_;
   scoped_ptr<media::AudioLog> audio_log_;
+
+ private:
+  static media::AudioParameters MakeAudioParams() {
+    media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LINEAR,
+                                  media::CHANNEL_LAYOUT_MONO, 48000, 16, 128);
+    params.set_effects(media::AudioParameters::ECHO_CANCELLER |
+                       media::AudioParameters::DUCKING);
+    return params;
+  }
 };
 
 TEST_P(MediaInternalsAudioLogTest, AudioLogCreateStartStopErrorClose) {
   audio_log_->OnCreated(kTestComponentID, test_params_, kTestDeviceID);
   base::RunLoop().RunUntilIdle();
 
   ExpectString("channel_layout",
                media::ChannelLayoutToString(test_params_.channel_layout()));
   ExpectInt("sample_rate", test_params_.sample_rate());
   ExpectInt("frames_per_buffer", test_params_.frames_per_buffer());
@@ skipping 38 matching lines @@
   ExpectStatus("closed");
 }
 
 INSTANTIATE_TEST_CASE_P(
     MediaInternalsAudioLogTest, MediaInternalsAudioLogTest, testing::Values(
         media::AudioLogFactory::AUDIO_INPUT_CONTROLLER,
         media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER,
         media::AudioLogFactory::AUDIO_OUTPUT_STREAM));
 
 }  // namespace content