Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: Source/core/layout/LayoutBlock.cpp

Issue 1304953005: Add some class documentation to LayoutBlock (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated after Morten's review. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/layout/LayoutBlock.h ('K') | « Source/core/layout/LayoutBlock.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutBlock.cpp
diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp
index f9a4e434cf19610c9211a54a49f60fc627167371..5ae6c0fc4d71b03e631f5569c9ac13e760173691 100644
--- a/Source/core/layout/LayoutBlock.cpp
+++ b/Source/core/layout/LayoutBlock.cpp
@@ -88,7 +88,18 @@ struct SameSizeAsLayoutBlock : public LayoutBox {
static_assert(sizeof(LayoutBlock) == sizeof(SameSizeAsLayoutBlock), "LayoutBlock should stay small");
+// This map keeps track of the positioned objects associated with a containing block.
+//
+// This map is populated during layout. It is kept across layouts to handle sub-tree
+// layouts. The map could be invalidated during style change but keeping track of
mstensho (USE GERRIT) 2015/08/31 19:28:52 You mean "handle that we skip unchanged subtrees d
Julien - ping for review 2015/08/31 21:55:29 Me gusta! Changed for your less hand-wavy explanat
+// containing blocks at that time is complicated (we are in the middle of
+// recomputing the style so we can't rely on any of its information), which is why
+// it's easier to just update it for every layout.
static TrackedDescendantsMap* gPositionedDescendantsMap = nullptr;
+
+// This map keeps track of the descendants whose 'height' is percentage associated
+// with a containing block. Like |gPositionedDescendantsMap|, it is also recomputed
+// for every layout (see the comment above about why).
static TrackedDescendantsMap* gPercentHeightDescendantsMap = nullptr;
static TrackedContainerMap* gPositionedContainerMap = nullptr;
« Source/core/layout/LayoutBlock.h ('K') | « Source/core/layout/LayoutBlock.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698