Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1304953002: LayoutTests for the new MSE GC behavior. (Closed)

Created:
5 years, 4 months ago by servolk
Modified:
5 years, 4 months ago
Reviewers:
philipj_slow, wolenetz
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@mse-gc5
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

LayoutTests for the new MSE GC behavior. These unit tests verify that QuotaExceededErr is thrown when appending data to an MSE SourceBuffer that is full. This new behavior was ntroduced by the recent CLs: https://codereview.chromium.org/1008463002/ https://codereview.chromium.org/1013923002/ BUG=421694 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201032

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the appendStream test #

Patch Set 3 : New test case for error event sent from async appendStream #

Messages

Total messages: 10 (4 generated)
philipj_slow
I gues BUG=421694?
5 years, 4 months ago (2015-08-21 08:21:54 UTC) #2
philipj_slow
LGTM, I just checked that these are the same as in https://codereview.chromium.org/1013923002/#ps260001
5 years, 4 months ago (2015-08-21 08:25:22 UTC) #3
wolenetz
lgtm % please update CL description to: Refer to the previous chain of Blink and ...
5 years, 4 months ago (2015-08-21 20:11:15 UTC) #5
wolenetz
Currently pending servolk@'s update from chat, that will add another appendStream test that looks for ...
5 years, 4 months ago (2015-08-22 00:24:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304953002/40001
5 years, 4 months ago (2015-08-22 00:50:55 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 01:36:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201032

Powered by Google App Engine
This is Rietveld 408576698