chrome/browser/ui/views/frame/browser_view.cc - Issue 1304943006: ProfileChooserVIew heap-use-after-free fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1304943006: ProfileChooserVIew heap-use-after-free fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index daa6b383a9cbb009daed2715af3103486f747037..93ea11764247da03a47f8b1f50f96ffaeedf8ed3 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2522,6 +2522,9 @@ void BrowserView::ShowAvatarBubbleFromAvatarButton(

AvatarBubbleMode mode,

const signin::ManageAccountsParams& manage_accounts_params) {

#if defined(FRAME_AVATAR_BUTTON)

+ // Do not show avatar bubble if there is no avatar menu button.

+ if (!frame_->GetNewAvatarMenuButton())

+ return;

profiles::BubbleViewMode bubble_view_mode;

profiles::TutorialMode tutorial_mode;

profiles::BubbleViewModeFromAvatarBubbleMode(mode, &bubble_view_mode,