Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1304943004: Revert of Make m_executeScriptsWaitingForResourcesTimer a loading task (Closed)

Created:
5 years, 3 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 3 months ago
Reviewers:
Mike West, Sami
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Make m_executeScriptsWaitingForResourcesTimer a loading task (patchset #2 id:20001 of https://codereview.chromium.org/1312353004/ ) Reason for revert: Oilpan leaks. Original issue's description: > Make m_executeScriptsWaitingForResourcesTimer a loading task > > We would like to be able to prioritize loading tasks, but in order to > do that we need to make sure loading tasks are posted to the right queue > to make sure tasks run in the expected order. If this task is posted as > a timer, and loading tasks are prioritzed, it's possible > FrameHostMsg_DidStopLoading will be sent before the corresponding > FrameHostMsg_DidStartLoading ipc which causes various browser tests to > break. > > BUG=497761, 510398 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201563 TBR=mkwst@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497761, 510398 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M Source/core/dom/Document.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alex clarke (OOO till 29th)
Created Revert of Make m_executeScriptsWaitingForResourcesTimer a loading task
5 years, 3 months ago (2015-09-02 13:01:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304943004/1
5 years, 3 months ago (2015-09-02 13:01:39 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 13:02:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201641

Powered by Google App Engine
This is Rietveld 408576698