Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304943002: DevTools: highlight attributes on selected DOM node (Closed)

Created:
5 years, 4 months ago by paulirish
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: highlight attributes on selected DOM node BUG=523165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201009

Patch Set 1 #

Total comments: 2

Patch Set 2 : lowercase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/devtools/front_end/elements/elementsTreeOutline.css View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
paulirish
5 years, 4 months ago (2015-08-21 01:14:09 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1304943002/diff/1/Source/devtools/front_end/elements/elementsTreeOutline.css File Source/devtools/front_end/elements/elementsTreeOutline.css (right): https://codereview.chromium.org/1304943002/diff/1/Source/devtools/front_end/elements/elementsTreeOutline.css#newcode309 Source/devtools/front_end/elements/elementsTreeOutline.css:309: color: #A5A5A5; #a5a5a5 https://codereview.chromium.org/1304943002/diff/1/Source/devtools/front_end/elements/elementsTreeOutline.css#newcode321 Source/devtools/front_end/elements/elementsTreeOutline.css:321: color: #CCCCCC; #ccc
5 years, 4 months ago (2015-08-21 01:36:46 UTC) #3
paulirish
On 2015/08/21 at 01:36:46, pfeldman wrote: > lgtm > > https://codereview.chromium.org/1304943002/diff/1/Source/devtools/front_end/elements/elementsTreeOutline.css > File Source/devtools/front_end/elements/elementsTreeOutline.css (right): ...
5 years, 4 months ago (2015-08-21 01:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304943002/20001
5 years, 4 months ago (2015-08-21 18:27:28 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 20:29:28 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201009

Powered by Google App Engine
This is Rietveld 408576698