Remove unnecessary fields from VoE SharedData.

webrtc/voice_engine/voe_base_impl.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 624 matching lines @@
 
 #ifdef WEBRTC_EXTERNAL_TRANSPORT
 int32_t VoEBaseImpl::AddExternalTransportBuild(char* str) const {
   return sprintf(str, "External transport build\n");
 }
 #endif
 
 int VoEBaseImpl::LastError() { return (shared_->statistics().LastError()); }
 
 int32_t VoEBaseImpl::StartPlayout() {
-  if (shared_->audio_device()->Playing()) {
-    return 0;
-  }
-  if (!shared_->ext_playout()) {
+  if (!shared_->audio_device()->Playing()) {
     if (shared_->audio_device()->InitPlayout() != 0) {
       LOG_F(LS_ERROR) << "Failed to initialize playout";
       return -1;
     }
     if (shared_->audio_device()->StartPlayout() != 0) {
       LOG_F(LS_ERROR) << "Failed to start playout";
       return -1;
     }
   }
   return 0;
 }
 
 int32_t VoEBaseImpl::StopPlayout() {
   // Stop audio-device playing if no channel is playing out
   if (shared_->NumOfPlayingChannels() == 0) {
     if (shared_->audio_device()->StopPlayout() != 0) {
       shared_->SetLastError(VE_CANNOT_STOP_PLAYOUT, kTraceError,
                             "StopPlayout() failed to stop playout");
       return -1;
     }
   }
   return 0;
 }
 
 int32_t VoEBaseImpl::StartSend() {
-  if (shared_->audio_device()->Recording()) {
-    return 0;
-  }
-  if (!shared_->ext_recording()) {
+  if (!shared_->audio_device()->Recording()) {
     if (shared_->audio_device()->InitRecording() != 0) {
       LOG_F(LS_ERROR) << "Failed to initialize recording";
       return -1;
     }
     if (shared_->audio_device()->StartRecording() != 0) {
       LOG_F(LS_ERROR) << "Failed to start recording";
       return -1;
     }
   }
-
   return 0;
 }
 
 int32_t VoEBaseImpl::StopSend() {
   if (shared_->NumOfSendingChannels() == 0 &&
       !shared_->transmit_mixer()->IsRecordingMic()) {
     // Stop audio-device recording if no channel is recording
     if (shared_->audio_device()->StopRecording() != 0) {
       shared_->SetLastError(VE_CANNOT_STOP_RECORDING, kTraceError,
                             "StopSend() failed to stop recording");
@@ skipping 170 matching lines @@
     shared_->SetLastError(VE_CHANNEL_NOT_VALID, kTraceError,
         "AssociateSendChannel() failed to locate accociate_send_channel");
     return -1;
   }
 
   channel_ptr->set_associate_send_channel(ch);
   return 0;
 }
 
 }  // namespace webrtc