Issue 130493003: Alternative approach to supporting ref counting and garbage collection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130493003: Alternative approach to supporting ref counting and garbage collection (Closed)

Created:
6 years, 11 months ago by Mads Ager (chromium)

Modified:
6 years, 11 months ago

Reviewers:
jamesr, Vyacheslav Egorov (Chromium), zerny-chromium, Erik Corry, jbroman, abarth-chromium, Nico, darin (slow to review)

CC:
blink-reviews, loislo+blink_chromium.org, Mads Ager (chromium), yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, haraken, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Alternative approach to supporting ref counting and garbage collection with the same code base. The code is spread out more but is avoids the macros entirely. The '::' also separates the new type and the old type very clearly. It also makes my eyes bleed a bit, but what do you think? BUG=

Patch Set 1 #

Patch Set 2 : Fix copyright. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+320 lines, -55 lines)			Patch
M	Source/heap/Handle.h	View		7 chunks	+53 lines, -0 lines	0 comments	Download
M	Source/heap/Heap.h	View		4 chunks	+25 lines, -0 lines	0 comments	Download
M	Source/heap/HeapTest.cpp	View	1	2 chunks	+196 lines, -0 lines	0 comments	Download
A +	Source/wtf/Ptr.h	View	1	2 chunks	+46 lines, -55 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

6 years, 11 months ago (2014-01-15 15:24:31 UTC) #1

This is Darin's suggestion from the blink-dev mailing list.

Compare to https://codereview.chromium.org/137483003

The '::' makes my eyes bleed a bit, but it also has the advantage that the types
are clearly separated. I can definitely work with both of the suggestions here.

Expand Messages | Collapse Messages