Handle the PrimeLint SSL read timeout better.

gcl.py

Index: gcl.py
diff --git a/gcl.py b/gcl.py
index db1e5b3eb9b46e8db34b509014beeb631b84cb6b..4bfc29bd882410152dde8f4281edec899e8bf4d5 100755
--- a/gcl.py
+++ b/gcl.py
@@ -13,6 +13,7 @@ import optparse
 import os
 import random
 import re
+import ssl
 import string
 import sys
 import tempfile
@@ -400,8 +401,16 @@ class ChangeInfo(object):
     """Do background work on Rietveld to lint the file so that the results are
     ready when the issue is viewed."""
     if self.issue and self.patchset:
-      self.SendToRietveld('/lint/issue%s_%s' % (self.issue, self.patchset),
-          timeout=10)
+      try:

[M-A Ruel, 2014/01/09 02:08:14]

You could remove the call completely.

[wtc, 2014/01/09 15:07:34]

Does "git cl upload" also run lint job on Rietveld? If not, I guess gcl.py
doesn't need to do this.

Do you know if '/lint/issue%s_%s' really lints the files in the background, as
the comment on line 401 and the function name "PrimeLint" imply? The root cause
of this bug may be that '/lint/issue%s_%s' is waiting for the completion of
lint.

[wtc, 2014/01/09 17:58:27]

Thanks for the reply.

I suspect the "background work" and the "PrimeLint" function name are referring
to the fact that we invoke '/lint/issue%s_%s' with a short timeout. The timeout
needs to be long enough to ensure the lint job gets started, but we are not
interested in waiting for the completion of lint.

So I've changed the timeout back to 10 seconds, and just silently ignore the
expected timeout error.

+        print "Linting the CL on Rietveld..."
+        self.SendToRietveld('/lint/issue%s_%s' % (self.issue, self.patchset),
+            timeout=60)
+        print "Lint done"
+      except ssl.SSLError as e:
+        if e.message == 'The read operation timed out':
+          print "Rietveld took too long to lint the CL. Read timeout ignored."
+        else:
+          raise
 
   def SendToRietveld(self, request_path, timeout=None, **kwargs):
     """Send a POST/GET to Rietveld.  Returns the response body."""