Only user gesture focus change and mouse click show autofill.

components/autofill/content/renderer/page_click_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/page_click_tracker.h"
 
 #include "base/command_line.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_listener.h"
 #include "components/autofill/core/common/autofill_util.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/platform/WebPoint.h"
 #include "third_party/WebKit/public/platform/WebSize.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebHitTestResult.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebTextAreaElement.h"
+#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 using blink::WebElement;
 using blink::WebGestureEvent;
 using blink::WebInputElement;
 using blink::WebInputEvent;
 using blink::WebMouseEvent;
 using blink::WebNode;
 using blink::WebPoint;
 using blink::WebSize;
 using blink::WebTextAreaElement;
+using blink::WebUserGestureIndicator;
 
 namespace {
 
 // Casts |node| to a WebInputElement.
 // Returns an empty (isNull()) WebInputElement if |node| is not a text field.
 const WebInputElement GetTextWebInputElement(const WebNode& node) {
   if (!node.isElementNode())
     return WebInputElement();
   const WebElement element = node.toConst<WebElement>();
   if (!element.hasHTMLTagName("input"))
@@ skipping 28 matching lines @@
       listener_(listener),
       legacy_(this) {
 }
 
 PageClickTracker::~PageClickTracker() {
 }
 
 void PageClickTracker::OnMouseDown(const WebNode& mouse_down_node) {
   focused_node_was_last_clicked_ = !mouse_down_node.isNull() &&
                                    mouse_down_node.focused();
+
+  if (IsKeyboardAccessoryEnabled())
+    DoFocusChangeComplete();
 }
 
 void PageClickTracker::FocusedNodeChanged(const WebNode& node) {
+  if (!WebUserGestureIndicator::isProcessingUserGesture())
+    return;

[Evan Stade, 2015/09/08 18:13:01]

I don't think it's right to early return before you change
was_focused_before_now_

[please use gerrit instead, 2015/09/08 21:18:08]

Moved the early return before changing was_focused_before_now_.

+
   was_focused_before_now_ = false;
 
   if (IsKeyboardAccessoryEnabled()) {
     focused_node_was_last_clicked_ = true;
     DoFocusChangeComplete();
   }
 }
 
 void PageClickTracker::FocusChangeComplete() {
   if (IsKeyboardAccessoryEnabled())
@@ skipping 36 matching lines @@
 
 void PageClickTracker::Legacy::OnMouseDown(const WebNode& mouse_down_node) {
   tracker_->OnMouseDown(mouse_down_node);
 }
 
 void PageClickTracker::Legacy::FocusChangeComplete() {
   tracker_->FocusChangeComplete();
 }
 
 }  // namespace autofill