Only user gesture focus change and mouse click show autofill.

components/autofill/content/renderer/page_click_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/page_click_tracker.h"
 
 #include "base/command_line.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_listener.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/platform/WebPoint.h"
 #include "third_party/WebKit/public/platform/WebSize.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebHitTestResult.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebTextAreaElement.h"
+#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 using blink::WebElement;
 using blink::WebGestureEvent;
 using blink::WebInputElement;
 using blink::WebInputEvent;
 using blink::WebMouseEvent;
 using blink::WebNode;
 using blink::WebPoint;
 using blink::WebSize;
 using blink::WebTextAreaElement;
+using blink::WebUserGestureIndicator;
 
 namespace {
 
 // Casts |node| to a WebInputElement.
 // Returns an empty (isNull()) WebInputElement if |node| is not a text field.
 const WebInputElement GetTextWebInputElement(const WebNode& node) {
   if (!node.isElementNode())
     return WebInputElement();
   const WebElement element = node.toConst<WebElement>();
   if (!element.hasHTMLTagName("input"))
@@ skipping 25 matching lines @@
     : content::RenderFrameObserver(render_frame),
       focused_node_was_last_clicked_(false),
       was_focused_before_now_(false),
       listener_(listener),
       legacy_(this) {
 }
 
 PageClickTracker::~PageClickTracker() {
 }
 
 void PageClickTracker::OnMouseDown(const WebNode& mouse_down_node) {

[Evan Stade, 2015/08/21 15:16:19]

does a tap count as a "mouse down" here? if not why is there no tap handling

[please use gerrit instead, 2015/08/24 17:58:42]

See http://crrev.com/1195473005 for context. Both click and tap will do
hit-testing to figure out which node is hit and call OnMouseDown(node) for the
node that was hit.

+  if (!WebUserGestureIndicator::isProcessingUserGesture())

[Evan Stade, 2015/08/21 15:16:19]

schwa?

How can you have onmousedown that's not a user gesture?

[please use gerrit instead, 2015/08/24 17:58:42]

I expected document.getElementsByTagName('input')[0].click() to trigger a non
user gesture mouse down event, but testing revealed my assumption was wrong.
Removed.

+    return;
+
   focused_node_was_last_clicked_ = !mouse_down_node.isNull() &&
                                    mouse_down_node.focused();
+
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableAccessorySuggestionView)) {
+    DoFocusChangeComplete();

[Evan Stade, 2015/08/21 15:16:19]

remind me why we need different handling on android and desktop

if you can show the popup on desktop without a user gesture that also seems bad

[please use gerrit instead, 2015/08/24 17:58:42]

We need different handling for keyboard accessory and popup, not android and
desktop.

The popup is attached to the input field, so we are showing it after the page
stops zooming and scrolling the input field into view. That happens when you tap
on the field. The callback for that event is FocuseChangeComplete().

The keyboard accessory is attached to the keyboard. It makes the content area
shorter by 48dp. Therefore, it does not depend on the input field position. In
fact, it's the opposite: the input field position is affected by the keyboard
accessory presence. Showing the keyboard accessory in FocusChangeComplete()
could cause a secondary zoom and scroll animation. That would look bad.
Therefore, we should show the keyboard accessory in FocusedNodeChanged(), which
is before the zoom/scroll animation. That way only one zoom/scroll animation
will happen.

Another good question would be: why should OnMouseDown() show the keyboard
accessory, but not the popup. Both OnMouseDown() and FocusedNodeChanged() will
be followed by FocusChangeComplete(). FocusChangeComplete() is actually a bad
name, but I have not been able to come up with a better name, unfortunately. One
candidate was OnImeShownAnimationsComplete(). See http://crrev.com/886663002 for
context. Since FocusChangeComplete() shows the autofill popup, no changes are
needed here.

As for the keyboard accessory, it needs to be shown in OnMouseDown() for the
following repro case:

1) User taps on input field -> This shows keyboard and accessory.

2) User taps the triangle to hide the keyboard -> This hides the accessory, but
the input field is still focused.

3) User taps the input field again -> The keyboard shows, but the accessory will
not be shown, because there was no focus change.
 
I have not been able to trigger the popup on desktop without a user gesture.
However, both autofocus and JavaScript can trigger FocusedNodeChanged(), so the
keyboard accessory needs to check user gesture.

+  }
 }
 
 void PageClickTracker::FocusedNodeChanged(const WebNode& node) {
+  if (!WebUserGestureIndicator::isProcessingUserGesture())
+    return;
+
   was_focused_before_now_ = false;
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableAccessorySuggestionView)) {
     focused_node_was_last_clicked_ = true;
     DoFocusChangeComplete();
   }
 }
 
 void PageClickTracker::FocusChangeComplete() {
@@ skipping 39 matching lines @@
 
 void PageClickTracker::Legacy::OnMouseDown(const WebNode& mouse_down_node) {
   tracker_->OnMouseDown(mouse_down_node);
 }
 
 void PageClickTracker::Legacy::FocusChangeComplete() {
   tracker_->FocusChangeComplete();
 }
 
 }  // namespace autofill