Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1304893010: X87: [builtins] Pass correct number of arguments after adapting arguments. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Pass correct number of arguments after adapting arguments. port fbad63669e309e8c5c3f2ecf503df2fefaac79bb (r30467) original commit message: The call protocol requires that the register dedicated to the number of actual arguments (i.e. rax on x64) always contains the actual arguments. That means after adapting arguments it should match the number of expected arguments. But currently we pass some semi-random value (usually some stack address) after adapting arguments. It looks like this is currently not observable anywhere, because our builtins and functions either don't look at the number of arguments and just make hard coded (unchecked) assumptions, or are marked as "don't adapt arguments", which bypasses the broken code in the trampoline for arguments adaption. Nevertheless this should be fixed. BUG= Committed: https://crrev.com/4d6eef61b751457f50c63bfb320ca20ccdf3c7e9 Cr-Commit-Position: refs/heads/master@{#30605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:18:40 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:16:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304893010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304893010/1
5 years, 3 months ago (2015-09-07 07:16:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 07:42:56 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 07:43:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d6eef61b751457f50c63bfb320ca20ccdf3c7e9
Cr-Commit-Position: refs/heads/master@{#30605}

Powered by Google App Engine
This is Rietveld 408576698