Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1304893008: Adds a common way to initialize logging (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, penghuang+watch-mandoline_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a common way to initialize logging This way you can use --v and other things and it'll work. BUG=none TEST=none R=jam@chromium.org Committed: https://crrev.com/8687467c6232548dc24b645b539752c453ee1c54 Cr-Commit-Position: refs/heads/master@{#346920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -9 lines) Patch
M components/html_viewer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/global_state.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + mojo/logging/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A mojo/logging/init_logging.h View 1 chunk +17 lines, -0 lines 0 comments Download
A mojo/logging/init_logging.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 3 months ago (2015-09-01 23:40:24 UTC) #1
jam
lgtm
5 years, 3 months ago (2015-09-02 05:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304893008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304893008/1
5 years, 3 months ago (2015-09-02 15:00:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 15:24:43 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 15:25:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8687467c6232548dc24b645b539752c453ee1c54
Cr-Commit-Position: refs/heads/master@{#346920}

Powered by Google App Engine
This is Rietveld 408576698