ui/file_manager/file_manager/foreground/js/ui/banners.js - Issue 1304883005: Make |context| passed to queryRequiredElement optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/banners.js

Issue 1304883005: Make |context| passed to queryRequiredElement optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whoops Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/tooltip_controller.js ('k') | ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/ui/banners.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/banners.js b/ui/file_manager/file_manager/foreground/js/ui/banners.js

index 817acc805da20b44f0750731e805b855734a7463..cf6c4d9ba782af0ae78a07ad6cbb052db02959ba 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/banners.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/banners.js

@@ -171,7 +171,7 @@ Banners.prototype.prepareAndShowWelcomeBanner_ = function(type, messageId) {

this.showWelcomeBanner_(type);

var container = queryRequiredElement(

- this.document_, '.drive-welcome.' + type);

+ '.drive-welcome.' + type, this.document_);

if (container.firstElementChild)

return; // Do not re-create.