Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 1304883005: Make |context| passed to queryRequiredElement optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whoops Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_manager.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js
index 994b1b281f7b2faabacd0dc662a68fc5bd072d1a..ac22931f231ee1a7d1ebb581170715b5ad20bfa9 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js
@@ -479,7 +479,7 @@ FileManager.prototype = /** @struct */ {
this.selectionHandler_,
this.directoryModel_);
this.tooltipController_ = new TooltipController(
- queryRequiredElement(this.dialogDom_, '#tooltip'),
+ queryRequiredElement('#tooltip', this.dialogDom_),
Array.prototype.slice.call(
this.dialogDom_.querySelectorAll('[has-tooltip]')));
this.emptyFolderController_ = new EmptyFolderController(
@@ -786,14 +786,14 @@ FileManager.prototype = /** @struct */ {
// Initialize the dialog.
FileManagerDialogBase.setFileManager(this);
- var table = queryRequiredElement(dom, '.detail-table');
+ var table = queryRequiredElement('.detail-table', dom);
FileTable.decorate(
table,
this.metadataModel_,
this.volumeManager_,
this.historyLoader_,
this.dialogType == DialogType.FULL_PAGE);
- var grid = queryRequiredElement(dom, '.thumbnail-grid');
+ var grid = queryRequiredElement('.thumbnail-grid', dom);
FileGrid.decorate(
grid,
this.metadataModel_,
@@ -806,7 +806,7 @@ FileManager.prototype = /** @struct */ {
assertInstanceof(table, FileTable),
assertInstanceof(grid, FileGrid),
new LocationLine(
- queryRequiredElement(dom, '#location-breadcrumbs'),
+ queryRequiredElement('#location-breadcrumbs', dom),
this.volumeManager_));
// Handle UI events.
« no previous file with comments | « ui/file_manager/file_manager/common/js/util.js ('k') | ui/file_manager/file_manager/foreground/js/file_transfer_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698