Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1304873011: Fix CPU profiler deadlock on Windows + AMD CPU. (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix CPU profiler deadlock on Windows + AMD CPU. Implement a lock free version of RolloverProtectedTickClock::Now to eliminate a deadlock. BUG=chromium:521420 LOG=Y Committed: https://crrev.com/d6db8e5902af1f067f0f149844f4e92824ee93f3 Cr-Commit-Position: refs/heads/master@{#30489} Committed: https://crrev.com/6184f1fef6692db2e89cacd380013a4a1bf7e8b1 Cr-Commit-Position: refs/heads/master@{#30522}

Patch Set 1 #

Patch Set 2 : use unsigned types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/base/platform/time.cc View 1 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873011/1
5 years, 3 months ago (2015-08-31 22:42:40 UTC) #2
alph
5 years, 3 months ago (2015-08-31 23:10:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 23:13:06 UTC) #6
yurys
lgtm
5 years, 3 months ago (2015-08-31 23:28:23 UTC) #7
alph
Benedikt, could you please take a look.
5 years, 3 months ago (2015-08-31 23:33:22 UTC) #9
Benedikt Meurer
LGTM.
5 years, 3 months ago (2015-09-01 03:16:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873011/1
5 years, 3 months ago (2015-09-01 04:01:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 04:02:40 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d6db8e5902af1f067f0f149844f4e92824ee93f3 Cr-Commit-Position: refs/heads/master@{#30489}
5 years, 3 months ago (2015-09-01 04:02:54 UTC) #14
alph
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1303423006/ by alph@chromium.org. ...
5 years, 3 months ago (2015-09-01 04:10:43 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873011/20001
5 years, 3 months ago (2015-09-01 17:33:20 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 18:29:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873011/20001
5 years, 3 months ago (2015-09-01 18:30:59 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 18:32:45 UTC) #23
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 18:32:58 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6184f1fef6692db2e89cacd380013a4a1bf7e8b1
Cr-Commit-Position: refs/heads/master@{#30522}

Powered by Google App Engine
This is Rietveld 408576698