Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1304873010: Use fast ELF symbolizer for symbols.py and tombstones (Closed)

Created:
5 years, 3 months ago by Menglin
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fast ELF symbolizer for symbols.py and tombstones Try to reduce stack_tool_with_logcat_dump time by using fast ELF symbolizer. The origin CL (https://codereview.chromium.org/164113003/) was created 1.5 yrs ago. This is an effort to check it in. BUG=463971 Committed: https://crrev.com/9c8f78855ca845ddd86d2daaec1fd1092eddd264 Cr-Commit-Position: refs/heads/master@{#346944}

Patch Set 1 #

Patch Set 2 : add an empty line in build/android/tombstones.py to trigger test run on trybot #

Patch Set 3 : add sym.source_line check to the _Callback #

Patch Set 4 : remove the empty line added in patchset2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 1 2 4 chunks +24 lines, -28 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Menglin
Hi Primiano, Please review this CL. Unfortunately, this doesn't reduce the stack_tool_with_logcat_dump time. I tried ...
5 years, 3 months ago (2015-09-01 16:06:12 UTC) #2
Primiano Tucci (use gerrit)
LGTM thanks. A tip on timing: I think most of the time is spent doing ...
5 years, 3 months ago (2015-09-01 16:15:53 UTC) #3
Menglin
+rmcilroy Please review this CL. It is primiano's CL (https://codereview.chromium.org/164113003/) 1.5 yrs ago with one ...
5 years, 3 months ago (2015-09-01 16:57:51 UTC) #5
rmcilroy
lgtm
5 years, 3 months ago (2015-09-02 10:14:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873010/40001
5 years, 3 months ago (2015-09-02 15:53:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/95728)
5 years, 3 months ago (2015-09-02 16:03:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873010/60001
5 years, 3 months ago (2015-09-02 16:53:27 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-02 17:03:53 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 17:04:36 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9c8f78855ca845ddd86d2daaec1fd1092eddd264
Cr-Commit-Position: refs/heads/master@{#346944}

Powered by Google App Engine
This is Rietveld 408576698