Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 1304863002: Revert of Preliminary change for new rtc rendering algorithm (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Preliminary change for new rtc rendering algorithm (patchset #15 id:400001 of https://codereview.chromium.org/1265433003/ ) Reason for revert: Blink layout test failures: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fvideo-capture* Original issue's description: > Preliminary change for new rtc rendering algorithm: > > 1. Add trace flags for smoothness testing > > 2. Propagate render_time calculated in Jitter Buffer to media::VideoFrame for new rendering algorithm to use. > > 3. Move invalidation trigger to compositor thread. > > BUG=514873 > > Committed: https://crrev.com/dde7ac68de3071061c47a1986a3344da0ffe1f7d > Cr-Commit-Position: refs/heads/master@{#344572} TBR=dalecurtis@chromium.org,mcasas@chromium.org,miu@chromium.org,sunnyps@chromium.org,piman@chromium.org,qiangchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514873 Committed: https://crrev.com/12f28e6acb22e283dfa0d046c4df1463de0779f0 Cr-Commit-Position: refs/heads/master@{#344590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -305 lines) Patch
M content/renderer/media/video_capture_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 4 chunks +32 lines, -73 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 15 chunks +104 lines, -193 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 5 chunks +1 line, -21 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/video_frame_metadata.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
Created Revert of Preliminary change for new rtc rendering algorithm
5 years, 4 months ago (2015-08-20 21:48:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304863002/1
5 years, 4 months ago (2015-08-20 21:50:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 21:53:52 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12f28e6acb22e283dfa0d046c4df1463de0779f0 Cr-Commit-Position: refs/heads/master@{#344590}
5 years, 4 months ago (2015-08-20 21:54:23 UTC) #4
qiangchen
On 2015/08/20 21:54:23, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 4 months ago (2015-08-20 23:55:51 UTC) #5
pfeldman
On 2015/08/20 23:55:51, qiangchenC wrote: > On 2015/08/20 21:54:23, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-08-21 00:02:48 UTC) #6
pfeldman
http://build.chromium.org/p/chromium.webkit/waterfall?last_time=1440109648
5 years, 4 months ago (2015-08-21 00:04:09 UTC) #7
qiangchen
On 2015/08/21 00:04:09, pfeldman wrote: > http://build.chromium.org/p/chromium.webkit/waterfall?last_time=1440109648 Thanks. It looks my guess is correct. After ...
5 years, 4 months ago (2015-08-21 18:34:21 UTC) #8
pfeldman
On 2015/08/21 18:34:21, qiangchenC wrote: > On 2015/08/21 00:04:09, pfeldman wrote: > > http://build.chromium.org/p/chromium.webkit/waterfall?last_time=1440109648 > ...
5 years, 4 months ago (2015-08-21 18:36:39 UTC) #9
qiangchen
5 years, 4 months ago (2015-08-21 19:10:18 UTC) #10
Message was sent while issue was closed.
On 2015/08/21 18:36:39, pfeldman wrote:
> On 2015/08/21 18:34:21, qiangchenC wrote:
> > On 2015/08/21 00:04:09, pfeldman wrote:
> > > http://build.chromium.org/p/chromium.webkit/waterfall?last_time=1440109648
> > 
> > Thanks. It looks my guess is correct. After handling no compositor thread
> case,
> > the code passes the webkit test.
> > 
> > Is there a way for me to go over the whole test procedure you ran on my CL?
So
> > that I can make sure nothing is broken 
> > before committing my code again.
> > in_reply_to: 5639274879778816
> > send_mail: 1
> > subject: Revert of Preliminary change for new rtc rendering algorithm
> 
> i'd ran it on a couple of bots that failed it and if it works, i would
re-land.

I've created https://codereview.chromium.org/1306203002 after rebase. Currently
running CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698