chrome/browser/resources/policy.js - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/policy.js

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed another test. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/policy.html ('k') | chrome/browser/search/contextual_search_policy_handler_android_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/policy.js

diff --git a/chrome/browser/resources/policy.js b/chrome/browser/resources/policy.js

index bec30a7caaef25080064288f05d06cc4624f7bb7..aaba4ff6e212501a0e9b9db32b1fd6648c9536bc 100644

--- a/chrome/browser/resources/policy.js

+++ b/chrome/browser/resources/policy.js

@@ -134,6 +134,8 @@ cr.define('policy', function() {

this.querySelector('.level').textContent =

loadTimeData.getString(value.level == 'recommended' ?

'levelRecommended' : 'levelMandatory');

+ this.querySelector('.source').textContent =

+ loadTimeData.getString(value.source);

this.querySelector('.value').textContent = value.value;

this.querySelector('.expanded-value').textContent = value.value;

}

@@ -519,7 +521,8 @@ cr.define('policy', function() {

var newTable = window.document.createElement('table');

var tableHead = window.document.createElement('thead');

var tableRow = window.document.createElement('tr');

- var tableHeadings = ['Scope', 'Level', 'Name', 'Value', 'Status'];

+ var tableHeadings = ['Scope', 'Level', 'Source', 'Name', 'Value',

+ 'Status'];

for (var i = 0; i < tableHeadings.length; i++) {

var tableHeader = window.document.createElement('th');

tableHeader.classList.add(tableHeadings[i].toLowerCase() + '-column');

« no previous file with comments | « chrome/browser/resources/policy.html ('k') | chrome/browser/search/contextual_search_policy_handler_android_unittest.cc » ('j') | no next file with comments »