components/policy/core/common/async_policy_provider_unittest.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/async_policy_provider_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browsertest and removed unnecessary string for default values. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/async_policy_provider.cc ('K') | « components/policy/core/common/async_policy_provider.cc ('k') | components/policy/core/common/cloud/cloud_policy_manager.h » ('j') | components/policy/core/common/cloud/cloud_policy_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/async_policy_provider_unittest.cc

diff --git a/components/policy/core/common/async_policy_provider_unittest.cc b/components/policy/core/common/async_policy_provider_unittest.cc

index 587d693c341fa546423e1d45efebbf57f731c953..2d3b1ca6c5d5ab6b5d3c5d13a4bd22385deadacf 100644

--- a/components/policy/core/common/async_policy_provider_unittest.cc

+++ b/components/policy/core/common/async_policy_provider_unittest.cc

@@ -47,6 +47,7 @@ class MockPolicyLoader : public AsyncPolicyLoader {

// call to MockLoad() which returns a PolicyBundle*, and returns a copy

// wrapped in a passed scoped_ptr.

scoped_ptr<PolicyBundle> Load() override;

+ PolicySource source() const override;

Thiemo Nagel 2015/09/01 17:40:36 Remove.

fhorschig 2015/09/04 06:53:54 Done.

MOCK_METHOD0(MockLoad, const PolicyBundle*());

MOCK_METHOD0(InitOnBackgroundThread, void());

@@ -72,6 +73,10 @@ scoped_ptr<PolicyBundle> MockPolicyLoader::Load() {

return bundle.Pass();

}

+PolicySource MockPolicyLoader::source() const {

Thiemo Nagel 2015/09/01 17:40:36 Remove.

fhorschig 2015/09/04 06:53:54 Done.

+ return POLICY_SOURCE_DEFAULT;

} // namespace

class AsyncPolicyProviderTest : public testing::Test {