components/policy/core/common/policy_service_impl.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_service_impl.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved policy source determiniation from providers to setting method. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/policy_map_unittest.cc ('K') | « components/policy/core/common/policy_map_unittest.cc ('k') | components/policy/core/common/policy_service_impl_unittest.cc » ('j') | components/policy/core/common/policy_service_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/policy_service_impl.cc

diff --git a/components/policy/core/common/policy_service_impl.cc b/components/policy/core/common/policy_service_impl.cc

index 96922ace797cebb1970bbf359acaa8f729bb74c1..5730d2387106828b64a7031671e07c6a4a968187 100644

--- a/components/policy/core/common/policy_service_impl.cc

+++ b/components/policy/core/common/policy_service_impl.cc

@@ -14,6 +14,7 @@

#include "base/values.h"

#include "components/policy/core/common/policy_bundle.h"

#include "components/policy/core/common/policy_map.h"

+#include "components/policy/core/common/policy_types.h"

#include "policy/policy_constants.h"

namespace policy {

@@ -64,6 +65,7 @@ void FixDeprecatedPolicies(PolicyMap* policies) {

policies->Set(key::kProxySettings,

current_priority.level,

current_priority.scope,

+ POLICY_SOURCE_BUILT_IN,

bartfab (slow) 2015/09/16 15:58:41 Nit: As discussed offline, it is probably better t

fhorschig 2015/09/17 11:20:42 Done.

proxy_settings.release(),

NULL);

}