components/policy/core/common/configuration_policy_provider.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/configuration_policy_provider.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved policy source determiniation from providers to setting method. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc ('K') | « components/policy/core/common/config_dir_policy_loader_unittest.cc ('k') | components/policy/core/common/configuration_policy_provider_test.h » ('j') | components/policy/core/common/policy_map_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/configuration_policy_provider.cc

diff --git a/components/policy/core/common/configuration_policy_provider.cc b/components/policy/core/common/configuration_policy_provider.cc

index 03fd8d7dd2accc22da17dec26372dcc034bebed8..105d43a55e514a54292cc3cbc42fd6108e4acec4 100644

--- a/components/policy/core/common/configuration_policy_provider.cc

+++ b/components/policy/core/common/configuration_policy_provider.cc

@@ -43,10 +43,11 @@ bool ConfigurationPolicyProvider::IsInitializationComplete(

void ConfigurationPolicyProvider::UpdatePolicy(

scoped_ptr<PolicyBundle> bundle) {

- if (bundle.get())

+ if (bundle.get()) {

bartfab (slow) 2015/09/16 15:58:41 Nit: You do not need curly braces for single-line

fhorschig 2015/09/17 11:20:42 Done.

policy_bundle_.Swap(bundle.get());

- else

+ } else {

policy_bundle_.Clear();

+ }

FOR_EACH_OBSERVER(ConfigurationPolicyProvider::Observer,

observer_list_,

OnUpdatePolicy(this));