components/policy/core/common/async_policy_provider_unittest.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/async_policy_provider_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved policy source determiniation from providers to setting method. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/policy_ui_browsertest.cc ('K') | « components/policy/core/browser/url_blacklist_policy_handler_unittest.cc ('k') | components/policy/core/common/cloud/cloud_policy_manager_unittest.cc » ('j') | components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/async_policy_provider_unittest.cc

diff --git a/components/policy/core/common/async_policy_provider_unittest.cc b/components/policy/core/common/async_policy_provider_unittest.cc

index 587d693c341fa546423e1d45efebbf57f731c953..d59dd90f27a70ae9344f6734e9485e83486130f9 100644

--- a/components/policy/core/common/async_policy_provider_unittest.cc

+++ b/components/policy/core/common/async_policy_provider_unittest.cc

@@ -12,6 +12,8 @@

#include "components/policy/core/common/async_policy_loader.h"

#include "components/policy/core/common/external_data_fetcher.h"

#include "components/policy/core/common/mock_configuration_policy_provider.h"

+#include "components/policy/core/common/policy_types.h"

bartfab (slow) 2015/09/16 15:58:41 Nit: Duplicate include.

fhorschig 2015/09/17 11:20:41 Done. (Arrggh!)

#include "components/policy/core/common/schema_registry.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -32,6 +34,7 @@ void SetPolicy(PolicyBundle* bundle,

.Set(name,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

+ POLICY_SOURCE_PLATFORM,

new base::StringValue(value),

NULL);

}