chrome/browser/ui/startup/startup_browser_creator_browsertest.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved policy source determiniation from providers to setting method. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc ('K') | « chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc ('k') | chrome/browser/ui/webui/options/certificate_manager_browsertest.cc » ('j') | chrome/browser/ui/webui/policy_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

index e5a280543a0d81a9e7706cb24b359618d88ae3db..80975b479a0b59e7b80262b22499b035c850f7de 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

@@ -1598,6 +1598,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,

policy::key::kRestoreOnStartup,

policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER,

+ POLICY_SOURCE_CLOUD,

new base::FundamentalValue(SessionStartupPref::kPrefValueURLs),

NULL);

base::ListValue startup_urls;

@@ -1605,7 +1606,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest,

new base::StringValue(test_server()->GetURL("files/title1.html").spec()));

policy_map_.Set(policy::key::kRestoreOnStartupURLs,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- startup_urls.DeepCopy(), NULL);

+ POLICY_SOURCE_CLOUD, startup_urls.DeepCopy(), nullptr);

provider_.UpdateChromePolicy(policy_map_);

base::RunLoop().RunUntilIdle();