Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/policy/core/common/policy_types.h

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/policy_types.h
diff --git a/components/policy/core/common/policy_types.h b/components/policy/core/common/policy_types.h
index 07289ca3ba04690360a82ab1752e3fa2ae86bb75..2b41047bbfc297eaa348735e4c5a875997b354b7 100644
--- a/components/policy/core/common/policy_types.h
+++ b/components/policy/core/common/policy_types.h
@@ -28,6 +28,28 @@ enum PolicyLevel {
POLICY_LEVEL_MANDATORY,
};
+// The source of a policy indicates where its value is originating from.
+enum PolicySource {
+ // The default value of a policy source.
+ POLICY_SOURCE_UNKNOWN,
+
+ // If the policy's default was determined by enterprise default settings.
bartfab (slow) 2015/09/14 14:42:27 Policies do not have defaults. They either are set
fhorschig 2015/09/16 13:52:05 Removed in the comment. The enum value should stil
+ POLICY_SOURCE_ENTERPRISE_DEFAULT,
+
+ // If the policy was programmatically set to an unchangeable value (e.g.
+ // to enforce ash tray visibility in public sessions).
+ POLICY_SOURCE_PROGRAMMATIC,
bartfab (slow) 2015/09/14 14:42:27 How about something like BUILT_IN instead?
fhorschig 2015/09/16 13:52:05 Good! We've been struggling with a good name.
+
+ // If the policy is set by a platform source.
+ POLICY_SOURCE_PLATFORM,
+
+ // If the policy originates from a cloud source.
bartfab (slow) 2015/09/14 14:42:27 Nit: Unlike German, English actually appreciates r
fhorschig 2015/09/16 13:52:05 Done.
+ POLICY_SOURCE_CLOUD,
+
+ // Number of source types. Has to be the last element.
+ POLICY_SOURCE_COUNT
+};
+
} // namespace policy
#endif // COMPONENTS_POLICY_CORE_COMMON_POLICY_TYPES_H_

Powered by Google App Engine
This is Rietveld 408576698