Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: components/policy/core/common/configuration_policy_provider_test.h

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/configuration_policy_provider_test.h
diff --git a/components/policy/core/common/configuration_policy_provider_test.h b/components/policy/core/common/configuration_policy_provider_test.h
index a8a0d4316b71b96a3765767c5bcc882318d62c13..4a19f855d692575433b7fa231fa447beb953bcd8 100644
--- a/components/policy/core/common/configuration_policy_provider_test.h
+++ b/components/policy/core/common/configuration_policy_provider_test.h
@@ -67,7 +67,9 @@ class PolicyProviderTestHarness {
public:
// |level| and |scope| are the level and scope of the policies returned by
// the providers from CreateProvider().
bartfab (slow) 2015/09/14 14:42:27 Nit: Document |source|.
fhorschig 2015/09/16 13:52:05 Done.
- PolicyProviderTestHarness(PolicyLevel level, PolicyScope scope);
+ PolicyProviderTestHarness(PolicyLevel level,
+ PolicyScope scope,
+ PolicySource source);
virtual ~PolicyProviderTestHarness();
// Actions to run at gtest SetUp() time.
@@ -81,6 +83,7 @@ class PolicyProviderTestHarness {
// Returns the policy level and scope set by the policy provider.
bartfab (slow) 2015/09/14 14:42:27 Nit: Update to document the source as well.
fhorschig 2015/09/16 13:52:05 Done.
PolicyLevel policy_level() const;
PolicyScope policy_scope() const;
+ PolicySource policy_source() const;
// Helpers to configure the environment the policy provider reads from.
virtual void InstallEmptyPolicy() = 0;
@@ -103,6 +106,7 @@ class PolicyProviderTestHarness {
private:
PolicyLevel level_;
PolicyScope scope_;
+ PolicySource source_;
DISALLOW_COPY_AND_ASSIGN(PolicyProviderTestHarness);
};

Powered by Google App Engine
This is Rietveld 408576698