components/policy/core/common/async_policy_provider_unittest.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/async_policy_provider_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/async_policy_provider.cc ('K') | « components/policy/core/common/async_policy_provider.cc ('k') | components/policy/core/common/cloud/cloud_policy_manager.cc » ('j') | components/policy/core/common/cloud/cloud_policy_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/async_policy_provider_unittest.cc

diff --git a/components/policy/core/common/async_policy_provider_unittest.cc b/components/policy/core/common/async_policy_provider_unittest.cc

index 587d693c341fa546423e1d45efebbf57f731c953..dfc8e4c05aabab92509007d1d761f22b29b4a437 100644

--- a/components/policy/core/common/async_policy_provider_unittest.cc

+++ b/components/policy/core/common/async_policy_provider_unittest.cc

@@ -29,11 +29,12 @@ void SetPolicy(PolicyBundle* bundle,

const std::string& name,

const std::string& value) {

bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

- .Set(name,

- POLICY_LEVEL_MANDATORY,

- POLICY_SCOPE_USER,

- new base::StringValue(value),

- NULL);

+ .SetWithSource(name,

+ POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_USER,

+ new base::StringValue(value),

+ NULL,

bartfab (slow) 2015/09/14 14:42:26 Nit: s/NULL/nullptr/

fhorschig 2015/09/16 13:52:04 Done.

+ POLICY_SOURCE_PLATFORM);

bartfab (slow) 2015/09/14 14:42:26 Nit: #include "components/policy/core/common/polic

fhorschig 2015/09/16 13:52:04 Done.

}

class MockPolicyLoader : public AsyncPolicyLoader {