components/policy/core/common/proxy_policy_provider.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/proxy_policy_provider.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Browsertest now checks one translated string. Refactoring according to review. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/policy_map.cc ('K') | « components/policy/core/common/policy_types.h ('k') | components/policy/core/common/schema_registry_tracking_policy_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/proxy_policy_provider.cc

diff --git a/components/policy/core/common/proxy_policy_provider.cc b/components/policy/core/common/proxy_policy_provider.cc

index 7a8919759c20fdbe9d0535a18f4df3e587518483..382f0a3992ea47b9c58feb051809065c14f8ac70 100644

--- a/components/policy/core/common/proxy_policy_provider.cc

+++ b/components/policy/core/common/proxy_policy_provider.cc

@@ -21,6 +21,7 @@ void ProxyPolicyProvider::SetDelegate(ConfigurationPolicyProvider* delegate) {

delegate_->RemoveObserver(this);

delegate_ = delegate;

if (delegate_) {

+ source_ = delegate_->source();

delegate_->AddObserver(this);

OnUpdatePolicy(delegate_);

} else {

@@ -35,6 +36,7 @@ void ProxyPolicyProvider::Shutdown() {

if (delegate_) {

delegate_->RemoveObserver(this);

delegate_ = NULL;

+ source_ = POLICY_SOURCE_UNKNOWN;

}

ConfigurationPolicyProvider::Shutdown();

}