chrome/browser/chromeos/policy/login_profile_policy_provider.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/login_profile_policy_provider.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Browsertest now checks one translated string. Refactoring according to review. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc ('K') | « chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc » ('j') | chrome/browser/ui/webui/policy_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/login_profile_policy_provider.cc

diff --git a/chrome/browser/chromeos/policy/login_profile_policy_provider.cc b/chrome/browser/chromeos/policy/login_profile_policy_provider.cc

index f0fe77feb84703eb00384998e5912f709d7fdc78..281e5c420044a60382833d99a293bdfcb3cfa3f8 100644

--- a/chrome/browser/chromeos/policy/login_profile_policy_provider.cc

+++ b/chrome/browser/chromeos/policy/login_profile_policy_provider.cc

@@ -90,6 +90,8 @@ LoginProfilePolicyProvider::LoginProfilePolicyProvider(

: device_policy_service_(device_policy_service),

waiting_for_device_policy_refresh_(false),

weak_factory_(this) {

+ // Policies for profiles must be set by an admin and thus come from the cloud.

Thiemo Nagel 2015/09/07 15:18:57 How about "All Chrome OS policies are coming from

fhorschig 2015/09/07 15:59:35 Much easier. I like it.

+ source_ = POLICY_SOURCE_CLOUD;

}

LoginProfilePolicyProvider::~LoginProfilePolicyProvider() {