Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed another test. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/prefs/pref_value_map.h" 7 #include "base/prefs/pref_value_map.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/net/disk_cache_dir_policy_handler.h" 9 #include "chrome/browser/net/disk_cache_dir_policy_handler.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
11 #include "components/policy/core/common/policy_map.h" 11 #include "components/policy/core/common/policy_map.h"
12 #include "components/policy/core/common/policy_types.h"
12 #include "policy/policy_constants.h" 13 #include "policy/policy_constants.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 15
15 namespace policy { 16 namespace policy {
16 17
17 class DiskCacheDirPolicyTest : public testing::Test { 18 class DiskCacheDirPolicyTest : public testing::Test {
18 protected: 19 protected:
19 PolicyMap policy_; 20 PolicyMap policy_;
20 DiskCacheDirPolicyHandler handler_; 21 DiskCacheDirPolicyHandler handler_;
21 PrefValueMap prefs_; 22 PrefValueMap prefs_;
22 }; 23 };
23 24
24 TEST_F(DiskCacheDirPolicyTest, Default) { 25 TEST_F(DiskCacheDirPolicyTest, Default) {
25 handler_.ApplyPolicySettings(policy_, &prefs_); 26 handler_.ApplyPolicySettings(policy_, &prefs_);
26 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL)); 27 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
27 } 28 }
28 29
29 TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) { 30 TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) {
30 // DiskCacheDir policy expects a string; give it a boolean. 31 // DiskCacheDir policy expects a string; give it a boolean.
31 policy_.Set(key::kDiskCacheDir, 32 policy_.Set(key::kDiskCacheDir,
32 POLICY_LEVEL_MANDATORY, 33 POLICY_LEVEL_MANDATORY,
33 POLICY_SCOPE_USER, 34 POLICY_SCOPE_USER,
35 POLICY_SOURCE_CLOUD,
34 new base::FundamentalValue(false), 36 new base::FundamentalValue(false),
35 NULL); 37 NULL);
36 handler_.ApplyPolicySettings(policy_, &prefs_); 38 handler_.ApplyPolicySettings(policy_, &prefs_);
37 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL)); 39 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
38 } 40 }
39 41
40 TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) { 42 TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) {
41 // Use a variable in the value. It should be expanded by the handler. 43 // Use a variable in the value. It should be expanded by the handler.
42 const std::string in = "${user_name}/foo"; 44 const std::string in = "${user_name}/foo";
43 policy_.Set(key::kDiskCacheDir, 45 policy_.Set(key::kDiskCacheDir,
44 POLICY_LEVEL_MANDATORY, 46 POLICY_LEVEL_MANDATORY,
45 POLICY_SCOPE_USER, 47 POLICY_SCOPE_USER,
48 POLICY_SOURCE_CLOUD,
46 new base::StringValue(in), 49 new base::StringValue(in),
47 NULL); 50 NULL);
48 handler_.ApplyPolicySettings(policy_, &prefs_); 51 handler_.ApplyPolicySettings(policy_, &prefs_);
49 52
50 const base::Value* value; 53 const base::Value* value;
51 ASSERT_TRUE(prefs_.GetValue(prefs::kDiskCacheDir, &value)); 54 ASSERT_TRUE(prefs_.GetValue(prefs::kDiskCacheDir, &value));
52 std::string out; 55 std::string out;
53 ASSERT_TRUE(value->GetAsString(&out)); 56 ASSERT_TRUE(value->GetAsString(&out));
54 EXPECT_NE(std::string::npos, out.find("foo")); 57 EXPECT_NE(std::string::npos, out.find("foo"));
55 EXPECT_EQ(std::string::npos, out.find("${user_name}")); 58 EXPECT_EQ(std::string::npos, out.find("${user_name}"));
56 } 59 }
57 60
58 } // namespace policy 61 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/extensions/policy_handlers_unittest.cc ('k') | chrome/browser/net/proxy_policy_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698