Add source column to chrome://policy showing the origins of policies.

components/policy/core/common/configuration_policy_provider.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_COMMON_CONFIGURATION_POLICY_PROVIDER_H_
 #define COMPONENTS_POLICY_CORE_COMMON_CONFIGURATION_POLICY_PROVIDER_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 56 matching lines @@
   virtual void RefreshPolicies() = 0;
 
   // Observers must detach themselves before the provider is deleted.
   virtual void AddObserver(Observer* observer);
   virtual void RemoveObserver(Observer* observer);
 
   // SchemaRegistry::Observer:
   void OnSchemaRegistryUpdated(bool has_new_schemas) override;
   void OnSchemaRegistryReady() override;
 
+  // Template Method used to inject a providers source into |UpdatePolicy|.

[Thiemo Nagel, 2015/09/01 17:40:37]

Could you please add a source_ member and make that a non-abstract getter
method?

[fhorschig, 2015/09/04 06:53:54]

Done.

+  virtual PolicySource source() const = 0;
+
  protected:
   // Subclasses must invoke this to update the policies currently served by
   // this provider. UpdatePolicy() takes ownership of |policies|.
   // The observers are notified after the policies are updated.
   void UpdatePolicy(scoped_ptr<PolicyBundle> bundle);
 
   SchemaRegistry* schema_registry() const;
 
   const scoped_refptr<SchemaMap>& schema_map() const;
 
  private:
+  // Used to tag all policies provided by this provider coming from a specific
+  // source.
+  void SetSources(PolicySource source);

[Thiemo Nagel, 2015/09/01 17:40:37]

Again I think it would be clearer to call this "SetSource".

[fhorschig, 2015/09/04 06:53:54]

The name is misleading. This function actually sets the sources of the Policies,
not of this provider.

+
   // The policies currently configured at this provider.
   PolicyBundle policy_bundle_;
 
   // Used to validate proper Init() and Shutdown() nesting. This flag is set by
   // Init() and cleared by Shutdown() and needs to be false in the destructor.
   bool initialized_;
 
   SchemaRegistry* schema_registry_;
 
   base::ObserverList<Observer, true> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ConfigurationPolicyProvider);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_COMMON_CONFIGURATION_POLICY_PROVIDER_H_