Add source column to chrome://policy showing the origins of policies.

chrome/browser/chromeos/policy/device_local_account_policy_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_local_account_policy_provider.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/policy/device_local_account.h"
 #include "chrome/browser/chromeos/policy/device_local_account_external_data_manager.h"
@@ skipping 38 matching lines @@
   }
 
   scoped_ptr<PolicyMap> chrome_policy_overrides;
   if (type == DeviceLocalAccount::TYPE_PUBLIC_SESSION) {
     chrome_policy_overrides.reset(new PolicyMap());
 
     // Exit the session when the lid is closed. The default behavior is to
     // suspend while leaving the session running, which is not desirable for
     // public sessions.
     chrome_policy_overrides->Set(
-        key::kLidCloseAction,
-        POLICY_LEVEL_MANDATORY,
-        POLICY_SCOPE_MACHINE,
+        key::kLidCloseAction, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,

[Thiemo Nagel, 2015/09/01 17:40:35]

Please try to avoid reformatting existing code.

[fhorschig, 2015/09/04 06:53:53]

Done.

         new base::FundamentalValue(
             chromeos::PowerPolicyController::ACTION_STOP_SESSION),
-        NULL);
+        NULL, POLICY_SOURCE_PLATFORM);

[Thiemo Nagel, 2015/09/01 17:40:35]

I'd consider defining a different source for this "injected" policy.

[fhorschig, 2015/09/04 06:53:53]

Done. Enforced policies are now of type ENFORCED.

     // Force the |ShelfAutoHideBehavior| policy to |Never|, ensuring that the
     // ash shelf does not auto-hide.
-    chrome_policy_overrides->Set(
-        key::kShelfAutoHideBehavior,
-        POLICY_LEVEL_MANDATORY,
-        POLICY_SCOPE_MACHINE,
-        new base::StringValue("Never"),
-        NULL);
+    chrome_policy_overrides->Set(key::kShelfAutoHideBehavior,
+                                 POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+                                 new base::StringValue("Never"), NULL,
+                                 POLICY_SOURCE_PLATFORM);

[Thiemo Nagel, 2015/09/01 17:40:35]

see above

[fhorschig, 2015/09/04 06:53:53]

Done.

     // Force the |ShowLogoutButtonInTray| policy to |true|, ensuring that a big,
     // red logout button is shown in the ash system tray.
-    chrome_policy_overrides->Set(
-        key::kShowLogoutButtonInTray,
-        POLICY_LEVEL_MANDATORY,
-        POLICY_SCOPE_MACHINE,
-        new base::FundamentalValue(true),
-        NULL);
+    chrome_policy_overrides->Set(key::kShowLogoutButtonInTray,
+                                 POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+                                 new base::FundamentalValue(true), NULL,
+                                 POLICY_SOURCE_PLATFORM);

[Thiemo Nagel, 2015/09/01 17:40:35]

see above

[fhorschig, 2015/09/04 06:53:53]

Done.

     // Force the |FullscreenAllowed| policy to |false|, ensuring that the ash
     // shelf cannot be hidden by entering fullscreen mode.
     chrome_policy_overrides->Set(
-        key::kFullscreenAllowed,
-        POLICY_LEVEL_MANDATORY,
-        POLICY_SCOPE_MACHINE,
-        new base::FundamentalValue(false),
-        NULL);
+        key::kFullscreenAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        new base::FundamentalValue(false), NULL, POLICY_SOURCE_PLATFORM);

[Thiemo Nagel, 2015/09/01 17:40:35]

see above

[fhorschig, 2015/09/04 06:53:53]

Done.

   }
 
   scoped_ptr<DeviceLocalAccountPolicyProvider> provider(
       new DeviceLocalAccountPolicyProvider(user_id,
                                            device_local_account_policy_service,
                                            chrome_policy_overrides.Pass()));
   return provider.Pass();
 }
 
 bool DeviceLocalAccountPolicyProvider::IsInitializationComplete(
@@ skipping 12 matching lines @@
   if (broker && broker->core()->service()) {
     waiting_for_policy_refresh_ = true;
     broker->core()->service()->RefreshPolicy(
         base::Bind(&DeviceLocalAccountPolicyProvider::ReportPolicyRefresh,
                    weak_factory_.GetWeakPtr()));
   } else {
     UpdateFromBroker();
   }
 }
 
+PolicySource DeviceLocalAccountPolicyProvider::source() const {

[Thiemo Nagel, 2015/09/01 17:40:35]

Remove.

[fhorschig, 2015/09/04 06:53:52]

Done.

+  return POLICY_SOURCE_PLATFORM;
+}
+
 void DeviceLocalAccountPolicyProvider::OnPolicyUpdated(
     const std::string& user_id) {
   if (user_id == user_id_)
     UpdateFromBroker();
 }
 
 void DeviceLocalAccountPolicyProvider::OnDeviceLocalAccountsChanged() {
   UpdateFromBroker();
 }
 
@@ skipping 32 matching lines @@
   }
 
   // Apply overrides.
   if (chrome_policy_overrides_) {
     PolicyMap& chrome_policy =
         bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
     for (PolicyMap::const_iterator it(chrome_policy_overrides_->begin());
          it != chrome_policy_overrides_->end();
          ++it) {
       const PolicyMap::Entry& entry = it->second;
-      chrome_policy.Set(
-          it->first, entry.level, entry.scope, entry.value->DeepCopy(), NULL);
+      chrome_policy.Set(it->first, entry.level, entry.scope,
+                        entry.value->DeepCopy(), NULL, POLICY_SOURCE_PLATFORM);
     }
   }
 
   UpdatePolicy(bundle.Pass());
 }
 
 }  // namespace policy