Add source column to chrome://policy showing the origins of policies.

components/policy/core/common/policy_map_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/policy_map.h"
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "components/policy/core/common/external_data_manager.h"
+#include "components/policy/core/common/policy_types.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 namespace {
 
 // Dummy policy names.
 const char kTestPolicyName1[] = "policy.test.1";
 const char kTestPolicyName2[] = "policy.test.2";
 const char kTestPolicyName3[] = "policy.test.3";
 const char kTestPolicyName4[] = "policy.test.4";
 const char kTestPolicyName5[] = "policy.test.5";
 const char kTestPolicyName6[] = "policy.test.6";
 const char kTestPolicyName7[] = "policy.test.7";
 const char kTestPolicyName8[] = "policy.test.8";
 
 // Utility functions for the tests.
 void SetPolicy(PolicyMap* map, const char* name, base::Value* value) {
-  map->Set(name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, value, NULL);
+  map->Set(name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+           value, nullptr);
 }
 
 void SetPolicy(PolicyMap* map,
                const char* name,
                ExternalDataFetcher* external_data_fetcher) {
-  map->Set(name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+  map->Set(name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
            NULL, external_data_fetcher);
 }
 
 }  // namespace
 
 class PolicyMapTest : public testing::Test {
  protected:
   scoped_ptr<ExternalDataFetcher> CreateExternalDataFetcher(
       const std::string& policy) const;
 };
@@ skipping 14 matching lines @@
   EXPECT_TRUE(expected_b.Equals(map.GetValue(kTestPolicyName1)));
   SetPolicy(&map, kTestPolicyName1,
             CreateExternalDataFetcher("dummy").release());
   EXPECT_FALSE(map.GetValue(kTestPolicyName1));
   const PolicyMap::Entry* entry = map.Get(kTestPolicyName1);
   ASSERT_TRUE(entry != NULL);
   EXPECT_EQ(POLICY_LEVEL_MANDATORY, entry->level);
   EXPECT_EQ(POLICY_SCOPE_USER, entry->scope);
   EXPECT_TRUE(ExternalDataFetcher::Equals(
       entry->external_data_fetcher, CreateExternalDataFetcher("dummy").get()));
-  map.Set(kTestPolicyName1, POLICY_LEVEL_RECOMMENDED,
-          POLICY_SCOPE_MACHINE, NULL, NULL);
+  map.Set(kTestPolicyName1, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_MACHINE,
+          POLICY_SOURCE_CLOUD, nullptr, nullptr);
   EXPECT_FALSE(map.GetValue(kTestPolicyName1));
   entry = map.Get(kTestPolicyName1);
   ASSERT_TRUE(entry != NULL);
   EXPECT_EQ(POLICY_LEVEL_RECOMMENDED, entry->level);
   EXPECT_EQ(POLICY_SCOPE_MACHINE, entry->scope);
   EXPECT_FALSE(entry->external_data_fetcher);
 }
 

[bartfab (slow), 2015/09/16 15:58:41]

Nit: Please include one or more of the other sources in the tests, to verify
that Set(), LoadFrom() and MergeFrom() set/copy sources as expected.

[fhorschig, 2015/09/17 11:20:42]

Done.

 TEST_F(PolicyMapTest, Equals) {
   PolicyMap a;
   SetPolicy(&a, kTestPolicyName1, new base::StringValue("aaa"));
   PolicyMap a2;
   SetPolicy(&a2, kTestPolicyName1, new base::StringValue("aaa"));
   PolicyMap b;
   SetPolicy(&b, kTestPolicyName1, new base::StringValue("bbb"));
   PolicyMap c;
   SetPolicy(&c, kTestPolicyName1, new base::StringValue("aaa"));
   SetPolicy(&c, kTestPolicyName2, new base::FundamentalValue(true));
@@ skipping 68 matching lines @@
   PolicyMap empty;
   EXPECT_TRUE(a.Equals(empty));
   EXPECT_FALSE(b.Equals(empty));
 }
 
 TEST_F(PolicyMapTest, MergeFrom) {
   PolicyMap a;
   a.Set(kTestPolicyName1,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("google.com"),
         NULL);
   a.Set(kTestPolicyName2,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
   a.Set(kTestPolicyName3,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("a").release());
   a.Set(kTestPolicyName4,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(false),
         NULL);
   a.Set(kTestPolicyName5,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("google.com/q={x}"),
         NULL);
 
   PolicyMap b;
   b.Set(kTestPolicyName1,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("chromium.org"),
         NULL);
   b.Set(kTestPolicyName2,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(false),
         NULL);
   b.Set(kTestPolicyName3,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("b").release());
   b.Set(kTestPolicyName4,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
   b.Set(kTestPolicyName5,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue(std::string()),
         NULL);
   b.Set(kTestPolicyName6,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
 
   a.MergeFrom(b);
 
   PolicyMap c;
   // POLICY_SCOPE_MACHINE over POLICY_SCOPE_USER.
   c.Set(kTestPolicyName1,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("chromium.org"),
         NULL);
   // |a| has precedence over |b|.
   c.Set(kTestPolicyName2,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
   c.Set(kTestPolicyName3,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("a").release());
   // POLICY_SCOPE_MACHINE over POLICY_SCOPE_USER for POLICY_LEVEL_RECOMMENDED.
   c.Set(kTestPolicyName4,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
   // POLICY_LEVEL_MANDATORY over POLICY_LEVEL_RECOMMENDED.
   c.Set(kTestPolicyName5,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue(std::string()),
         NULL);
   // Merge new ones.
   c.Set(kTestPolicyName6,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
 
   EXPECT_TRUE(a.Equals(c));
 }
 
 TEST_F(PolicyMapTest, GetDifferingKeys) {
   PolicyMap a;
   a.Set(kTestPolicyName1,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("google.com"),
         NULL);
   a.Set(kTestPolicyName2,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("dummy").release());
   a.Set(kTestPolicyName3,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
   a.Set(kTestPolicyName4,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("a").release());
   a.Set(kTestPolicyName5,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(false),
         NULL);
   a.Set(kTestPolicyName6,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("google.com/q={x}"),
         NULL);
   a.Set(kTestPolicyName7,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
 
   PolicyMap b;
   b.Set(kTestPolicyName1,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("google.com"),
         NULL);
   b.Set(kTestPolicyName2,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("dummy").release());
   b.Set(kTestPolicyName3,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(false),
         NULL);
   b.Set(kTestPolicyName4,
-        POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+        POLICY_LEVEL_MANDATORY,
+        POLICY_SCOPE_MACHINE,
+        POLICY_SOURCE_CLOUD,
         NULL, CreateExternalDataFetcher("b").release());
   b.Set(kTestPolicyName5,
         POLICY_LEVEL_MANDATORY,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(false),
         NULL);
   b.Set(kTestPolicyName6,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::StringValue("google.com/q={x}"),
         NULL);
   b.Set(kTestPolicyName8,
         POLICY_LEVEL_RECOMMENDED,
         POLICY_SCOPE_USER,
+        POLICY_SOURCE_CLOUD,
         new base::FundamentalValue(true),
         NULL);
 
   std::set<std::string> diff;
   std::set<std::string> diff2;
   a.GetDifferingKeys(b, &diff);
   b.GetDifferingKeys(a, &diff2);
   // Order shouldn't matter.
   EXPECT_EQ(diff, diff2);
   // No change.
   EXPECT_TRUE(diff.find(kTestPolicyName1) == diff.end());
   EXPECT_TRUE(diff.find(kTestPolicyName2) == diff.end());
   // Different values.
   EXPECT_TRUE(diff.find(kTestPolicyName3) != diff.end());
   // Different external data references.
   EXPECT_TRUE(diff.find(kTestPolicyName4) != diff.end());
   // Different levels.
   EXPECT_TRUE(diff.find(kTestPolicyName5) != diff.end());
   // Different scopes.
   EXPECT_TRUE(diff.find(kTestPolicyName6) != diff.end());
   // Not in |a|.
   EXPECT_TRUE(diff.find(kTestPolicyName8) != diff.end());
   // Not in |b|.
   EXPECT_TRUE(diff.find(kTestPolicyName7) != diff.end());
   // No surprises.
   EXPECT_EQ(6u, diff.size());
 }
 
 }  // namespace policy