Add source column to chrome://policy showing the origins of policies.

components/policy/tools/generate_policy_source.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''python %prog [options] platform chromium_os_flag template
 
 platform specifies which platform source is being generated for
   and can be one of (win, mac, linux)
 chromium_os_flag should be 1 if this is a Chromium OS build
@@ skipping 698 matching lines @@
         creation_expression = 'new base::FundamentalValue(%s)' %\
                               policy.enterprise_default
       elif policy.policy_type == 'TYPE_STRING':
         creation_expression = 'new base::StringValue("%s")' %\
                               policy.enterprise_default
       else:
         raise RuntimeError('Type %s of policy %s is not supported at '
                            'enterprise defaults' % (policy.policy_type,
                                                     policy.name))
       f.write('  if (!policy_map->Get(key::k%s)) {\n'
-              '    policy_map->Set(key::k%s,\n'
-              '                    POLICY_LEVEL_MANDATORY,\n'
-              '                    POLICY_SCOPE_USER,\n'
-              '                    %s,\n'
-              '                    NULL);\n'
+              '    policy_map->SetWithSource(key::k%s,\n'
+              '                              POLICY_LEVEL_MANDATORY,\n'
+              '                              POLICY_SCOPE_USER,\n'
+              '                              %s,\n'
+              '                              NULL,\n'

[bartfab (slow), 2015/09/14 14:42:28]

Nit: s/NULL/nullptr/

[fhorschig, 2015/09/16 13:52:06]

Done.

+              '                              '

[bartfab (slow), 2015/09/14 14:42:28]

Nit: Remove blank line.

[fhorschig, 2015/09/16 13:52:06]

Done.

+              'POLICY_SOURCE_ENTERPRISE_DEFAULT);\n'

[bartfab (slow), 2015/09/14 14:42:28]

1: Where is |POLICY_SOURCE_ENTERPRISE_DEFAULT| coming from? policy_types.h does
not define it.
2: Nit: If you indent four spaces after |policy_map| above, there should be no
need for this odd line break.
3: Nit: #include "components/policy/core/common/policy_types.h"

[fhorschig, 2015/09/16 13:52:06]

Done.

               '  }\n' % (policy.name, policy.name, creation_expression))
 
   f.write('}\n'
           '#endif\n\n')
 
   f.write('const PolicyDetails* GetChromePolicyDetails('
               'const std::string& policy) {\n'
           '  // First index in kPropertyNodes of the Chrome policies.\n'
           '  static const int begin_index = %s;\n'
           '  // One-past-the-end of the Chrome policies in kPropertyNodes.\n'
@@ skipping 314 matching lines @@
   # _WriteAppRestrictions body
   f.write('<restrictions xmlns:android="'
           'http://schemas.android.com/apk/res/android">\n\n')
   for policy in policies:
     if policy.is_supported and policy.restriction_type != 'invalid':
       WriteAppRestriction(policy)
   f.write('</restrictions>')
 
 if __name__ == '__main__':
   sys.exit(main())