Add source column to chrome://policy showing the origins of policies.

chrome/browser/ui/webui/policy_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/policy_ui.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 59 matching lines @@
 #include "extensions/browser/extension_registry_observer.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #endif
 
 namespace em = enterprise_management;
 
 namespace {
 
+// Strings that map from PolicySource enum to i18n strings.
+const char* const kSourceNameStrings[policy::POLICY_SOURCE_COUNT] = {"",

[Dan Beam, 2015/09/09 21:50:16]

eh, this is kinda weird.  why do we have to duplicate the key names?  i'd say
this would be better as:

struct PolicySourceMap {
  policy::PolicySource source;
  const char* key;
  int string_id;
};

const PolicySourceMap kPolicySources[] = {
  {policy::POLICY_SOURCE_ENTERPRISE,
   "sourceEnterprise",
   IDS_POLICY_SOURCE_ENTERPRISE},
  ...
};

[fhorschig, 2015/09/10 11:36:31]

Good idea! Was there a special reason to include the source itself into the
struct? Never used, so I spared it.

+    "sourceEnterprise", "sourceProgrammatic", "sourcePlatform", "sourceCloud"};
+
 content::WebUIDataSource* CreatePolicyUIHTMLSource() {
   content::WebUIDataSource* source =
       content::WebUIDataSource::Create(chrome::kChromeUIPolicyHost);
 
   // Localized strings.
   source->AddLocalizedString("title", IDS_POLICY_TITLE);
   source->AddLocalizedString("filterPlaceholder",
                              IDS_POLICY_FILTER_PLACEHOLDER);
   source->AddLocalizedString("reloadPolicies", IDS_POLICY_RELOAD_POLICIES);
   source->AddLocalizedString("status", IDS_POLICY_STATUS);
@@ skipping 11 matching lines @@
   source->AddLocalizedString("labelRefreshInterval",
                              IDS_POLICY_LABEL_REFRESH_INTERVAL);
   source->AddLocalizedString("labelStatus", IDS_POLICY_LABEL_STATUS);
   source->AddLocalizedString("showUnset", IDS_POLICY_SHOW_UNSET);
   source->AddLocalizedString("noPoliciesSet", IDS_POLICY_NO_POLICIES_SET);
   source->AddLocalizedString("headerScope", IDS_POLICY_HEADER_SCOPE);
   source->AddLocalizedString("headerLevel", IDS_POLICY_HEADER_LEVEL);
   source->AddLocalizedString("headerName", IDS_POLICY_HEADER_NAME);
   source->AddLocalizedString("headerValue", IDS_POLICY_HEADER_VALUE);
   source->AddLocalizedString("headerStatus", IDS_POLICY_HEADER_STATUS);
+  source->AddLocalizedString("headerSource", IDS_POLICY_HEADER_SOURCE);
   source->AddLocalizedString("showExpandedValue",
                              IDS_POLICY_SHOW_EXPANDED_VALUE);
   source->AddLocalizedString("hideExpandedValue",
                              IDS_POLICY_HIDE_EXPANDED_VALUE);
   source->AddLocalizedString("scopeUser", IDS_POLICY_SCOPE_USER);
   source->AddLocalizedString("scopeDevice", IDS_POLICY_SCOPE_DEVICE);
   source->AddLocalizedString("levelRecommended", IDS_POLICY_LEVEL_RECOMMENDED);
   source->AddLocalizedString("levelMandatory", IDS_POLICY_LEVEL_MANDATORY);
+  source->AddLocalizedString("sourceProgrammatic",
+                             IDS_POLICY_SOURCE_PROGRAMMATIC);
+  source->AddLocalizedString("sourceEnterprise", IDS_POLICY_SOURCE_ENTERPRISE);
+  source->AddLocalizedString("sourcePlatform", IDS_POLICY_SOURCE_PLATFORM);
+  source->AddLocalizedString("sourceCloud", IDS_POLICY_SOURCE_CLOUD);

[Dan Beam, 2015/09/09 21:50:16]

and use kPolicySources here

[fhorschig, 2015/09/10 11:36:31]

Done.

   source->AddLocalizedString("ok", IDS_POLICY_OK);
   source->AddLocalizedString("unset", IDS_POLICY_UNSET);
   source->AddLocalizedString("unknown", IDS_POLICY_UNKNOWN);
   source->AddLocalizedString("notSpecified", IDS_POLICY_NOT_SPECIFIED);
 
   source->SetJsonPath("strings.js");
 
   // Add required resources.
   source->AddResourcePath("policy.css", IDR_POLICY_CSS);
   source->AddResourcePath("policy.js", IDR_POLICY_JS);
@@ skipping 616 matching lines @@
     base::DictionaryValue* value = new base::DictionaryValue;
     value->Set("value", CopyAndConvert(entry->second.value).release());
     if (entry->second.scope == policy::POLICY_SCOPE_USER)
       value->SetString("scope", "user");
     else
       value->SetString("scope", "machine");
     if (entry->second.level == policy::POLICY_LEVEL_RECOMMENDED)
       value->SetString("level", "recommended");
     else
       value->SetString("level", "mandatory");
+    value->SetString("source", kSourceNameStrings[entry->second.source]);

[Dan Beam, 2015/09/09 21:50:16]

and here

[fhorschig, 2015/09/10 11:36:30]

Done.

     base::string16 error = errors->GetErrors(entry->first);
     if (!error.empty())
       value->SetString("error", error);
     values->Set(entry->first, value);
   }
 }
 
 void PolicyUIHandler::GetChromePolicyValues(
     base::DictionaryValue* values) const {
   policy::PolicyService* policy_service = GetPolicyService();
@@ skipping 72 matching lines @@
 }
 
 PolicyUI::PolicyUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new PolicyUIHandler);
   content::WebUIDataSource::Add(Profile::FromWebUI(web_ui),
                                 CreatePolicyUIHTMLSource());
 }
 
 PolicyUI::~PolicyUI() {
 }